Comments (9)
Looks right to me - by the way, I'm not working in this area any more so I'm not really the right person to review these PRs and issues 🙂
from bond-cni.
@killianmuldoon @Eoghan1232 could you please take a look?
from bond-cni.
apologies on delay, never got any notification on this.
Hi @mmirecki , agreed that the above is an issue.
I would prefer this approach:
getting rid of the "name" parameter in the config - api will be backwards incompatible
from bond-cni.
np, I only realized today that no one was added to the assignees.
Let me add a PR for this.
from bond-cni.
Fix proposal here:
#35
from bond-cni.
Looks right to me - by the way, I'm not working in this area any more so I'm not really the right person to review these PRs and issues slightly_smiling_face
I don't think anyone other than you and Eoghan can approve/merge here, so please don't abandon the repo :)
from bond-cni.
I don't think anyone other than you and Eoghan can approve/merge here, so please don't abandon the repo :)
@Eoghan1232 has it handled 🙂 But it would definitely be a good idea to add someone else as a maintainer. I'm happy to stay on the list to have some redundancy there - I'm still working in Kubernetes stuff, just no longer in the network plumbing group so I don't have any bandwidth to dedicate here.
from bond-cni.
@eoghanlawless is named as a maintainer on this repo, as well as @esiperu-est from what I see from the meeting notes.
from bond-cni.
Closing issue as PR has now been merged.
from bond-cni.
Related Issues (16)
- Issue with bonding (active-backup mode) HOT 8
- Bond iface does not work when active slave is teared down #12 HOT 2
- Bonding SR-IOV interfaces fails HOT 3
- SR-IOV and LACP HOT 1
- SRIOV WITH DPDK HOT 1
- IP assign for bond interface is not show in metadata
- GitHub Actions
- GitHub Actions #2
- Unit Tests
- Request to enhance Bond CNI to use resources discovered via the sriov device plugin HOT 4
- Failed to set vf 0 vlan: operation not supported HOT 1
- Bonding SR-IOV VFs in LACP mode fails HOT 1
- Unable to create Bond Interface HOT 5
- Pod hangs on terminating state due to missing slave interfaces
- Expose bond interface ip as external IP to kubernetes service
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bond-cni.