ipv4 ipsets require family inet and ipv6 ipsets requi

Different ipsets for ipv6 and ipv4 addresses about kube-router HOT 2 CLOSED

k3s-io commented on June 11, 2024

Different ipsets for ipv6 and ipv4 addresses

from kube-router.

Comments (2)

vadorovsky commented on June 11, 2024

Thanks for finding the issue! But I don't think your solution is correct. I made a mistake by putting that whole code inside the loop for ipFamily, ipset := range npc.ipsetHandlers.

I would rather remove the loop, create two separate setEntries slices, for each family and then explicitly call ipset tool of each family, like:

setEntriesv4 := make([][]string, 0)
setEntriesv6 := make([][]string, 0)
for _, podIP := range currentPodIps {
	if utilsnet.IsIPv4String(podIP.IP) {
		setEntriesv4 = append(setEntriesv4, []string{podIP.IP, utils.OptionTimeout, "0"})
	}
	if utilsnet.IsIPv6String(podIP.IP) {
		setEntriesv6 = append(setEntriesv6, []string{podIP.IP, utils.OptionTimeout, "0", "family", "inet6"})
	}

}
if npc.EnableIPv4 && len(setEntriesv4) > 0 {
	ipset[v1core.IPv4Protocol].RefreshSet(targetDestPodIPSetName, setEntriesv4, utils.TypeHashIP)
}
if npc.EnableIPv6 && len(setEntriesv6) > 0 {
	ipset[v1core.IPv6Protocol].RefreshSet(targetDestPodIPSetName, setEntriesv6, utils.TypeHashIP)
}