Code Monkey home page Code Monkey logo

Comments (9)

dweomer avatar dweomer commented on June 12, 2024

May need to apply this patch: http://git.netfilter.org/ebtables/commit/?id=3af72f100ad783b0204ce519de26a639f920b558

from k3s-root.

dweomer avatar dweomer commented on June 12, 2024

@manuelbuil @raulcabello did we decide if we cared about ebtables for s390x?

from k3s-root.

raulcabello avatar raulcabello commented on June 12, 2024

@dweomer if it is not used in rke2 we can remove it. What do you think @manuelbuil ?

from k3s-root.

manuelbuil avatar manuelbuil commented on June 12, 2024

@dweomer if it is not used in rke2 we can remove it. What do you think @manuelbuil ?

We should verify this. The general suspicion is that it was included just in case but we are not using it. However, nobody is 100% sure about it

from k3s-root.

raulcabello avatar raulcabello commented on June 12, 2024

we will find out if there are any issues with this while doing QA for s390x. I'll also try to find any reference to ebtables, but I could not find any until now.

from k3s-root.

dweomer avatar dweomer commented on June 12, 2024

I don't like the idea of leaving a segfaulting footgun laying around but if we are not using it for rke2 let's make sure we elide it from the rke2 runtime and we can then nervously leave it here as a "known" issue.

from k3s-root.

raulcabello avatar raulcabello commented on June 12, 2024

That make sense. Is it possible to not generate ebtables binary in buildroot just for s390x?

from k3s-root.

raulcabello avatar raulcabello commented on June 12, 2024

@dweomer please have a look to have a look to #48

from k3s-root.

dweomer avatar dweomer commented on June 12, 2024

Slack convo with @raulcabello and @manuelbuil:

Jacob Blain Christen 29 minutes ago
btw, ebtables-legacy --help segfaults for me on x86_64. this might be expected behavior without the backing ebtablesd running? (edited)

Raul Cabello 24 minutes ago
I don't know, but then it looks like it is not an issue with s390x. I started ebtablesd on s390x, and ebtables-legacy still crashes

Jacob Blain Christen 6 minutes ago
i think we just dont even know how to smoke test it so if it seems unused lets just leave it alone for now

Raul Cabello 3 minutes ago
ok, then we'll use https://github.com/k3s-io/k3s-root/releases/tag/v0.10.0-rc.2 for now. I'll submit PRs to use it (we are using v0.10.-0-rc.0) and I will close https://github.com/k3s-io/k3s-root/pull/48
#48 Do not generate ebtables for s390x
https://github.com/k3s-io/k3s-root|k3s-io/k3s-rootk3s-io/k3s-root | Today at 4:29 AM | Added by GitHub

from k3s-root.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.