Code Monkey home page Code Monkey logo

Comments (2)

k0001 avatar k0001 commented on August 21, 2024

Yeah, that commit reorganized much stuff. Mostly just a general cleanup.

In practice, I don't think there's much difference between the standalone type families vs. the typeclass and associated types approach in this case. I tried both, and the current one seemed a bit cleaner.

That thing you mention about things like SchemaName having a default is a minor but interesting point. I actually don't like the idea of providing a default here. With tisch, I'm trying to make it as hard as possible to shot yourself in the foot, and being explicit about things is a good way to achieve that. Granted, having a default schema name is not a big deal, but still I'd prefer people to understand where their tables are found so that they can better relate to the generated SQL, error messages, and such.

from tisch.

expipiplus1 avatar expipiplus1 commented on August 21, 2024

That's understandable regarding defaults.

One nice thing about doing this in a class is that there's one central place for the user to see what they need to define for their table to work.

If you say that it's cleaner this way I'm happy :)

from tisch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.