Code Monkey home page Code Monkey logo

Comments (1)

karlwilbur avatar karlwilbur commented on September 13, 2024 4

Thanks!

You are correct in that <script>alert()</script>@domain.com is very much not a valid email address. While <script>alert()</script>@domain.com is invalid, properly escaping user input when rendered as HTML would not allow that invalid email address to be executed as JavaScript. So, the only real consideration is that a clearly invalid email address is passing the simple validation check.

The "local-part" (username) characters in an email address should be limited to only /[a-z][-a-z0-9!#$%&'*+"=?^_`{}|~]{0,63}/, per RFC 2822. Your suggested alternative is not RFC compliant either; in fact the author calls it "madness". There was, at one point, a "strict mode" for this gem which had increased validation covering some of that. However, it is worth noting that the clearly stated validation philisophy of this gem (as of 2019-03-02) is to use an extremely loose interpretation of what constitutes an email address.

Yes, I have read The 100% correct way to validate email addresses and just simply disagree with the general "epiphany". While "send your users an activation email" is indisputably the best way to validate a users email address, what happens to other email address that aren't provided as part of user registration; one to which a confirmation/validation email should not be sent? What about parsing emails from another source than typed user input? A field validator has more reason for existence than to check for a user's typos.

FWIW, I use my fork of this repo (at a much earlier version) which implements a much more strict interpretation of a "valid" email address (e.g: karl is a strictly valid email address, per the RFCs). You are certainly welcome to use my fork, but I would very much like to see this official repo have proper email validation and agree that /[^\s]@[^\s]/ is entirely insufficient. I realize that my concerns are outside the defined scope of this gem, which is why I maintain my fork. I just wish that it weren't so.

from email_validator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.