<div class="snippet-clipboard-content notranslate position-relative overflow-auto" data-snippet-clip

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

"raw output" fails to encode about faq HOT 7 CLOSED

jzelinskie commented on May 29, 2024

"raw output" fails to encode

from faq.

Comments (7)

jzelinskie commented on May 29, 2024 1

@chancez maybe we should just add

if rawOutput {
  outputConf.Color = false
  outputConf.Pretty = false
}

above

faq/pkg/faq/faq.go

Lines 87 to 92 in ecc24ae

    
           for _, output := range outputs { 
        
           	err := encoder.UnmarshalJSONBytes([]byte(output), outputConf.Color, outputConf.Pretty) 
        
           	if err != nil { 
        
           		return err 
        
           	} 
        
           }

The original jq (and early faq) handled this at flag-parsing time, but it honestly seems more sane to do it at the call site.

from faq.

jzelinskie commented on May 29, 2024

This is on faq v0.0.6?

from faq.

vbatts commented on May 29, 2024

vbatts@infra1:~$ faq --version
0.0.6

from faq.

chancez commented on May 29, 2024

Try -ojson when using -r and maybe -c. I think it's broken with non-JSON output.

from faq.

vbatts commented on May 29, 2024

@chancez it already defaulted to json output. Adding that flag did not change anything.

vbatts@infra1:~$ curl -s https://api.github.com/repos/flatcar-linux/manifest/releases | faq -f json -o json -r '.[0].tag_name'
Error: failed to encode as pretty: invalid character 'v' looking for beginning of value
Usage:
  faq [flags] [filter string] [files...]
[...]

p.s. despite erroring out, the return code is from this is still 0

from faq.

chancez commented on May 29, 2024

Try -c. It's trying to pretty the raw output, which cannot be done.

from faq.

chancez commented on May 29, 2024

I'd agree with that.

from faq.

Recommend Projects