Comments (4)
When attempting #16, I was having weird issues with the tooltip. As described by the primary maintainer of shadcn-svelte,
basically the floating/popper components portal to the body by default to get around Z-index hell, etc.
I think this is the same issue here, but setting the portal
prop to null
within the UserSelect
custom component does not seem to be helping the strange layout shift when the dialog first opens. Attempting to set the openFocus
prop to [data-bits-dialog-close]
didn't seem to help me either.
I'm thinking I should create a small repro of this issue to work on it further, I'm feel somewhat certain the portal is related to this in some fashion as the Popover
and Dialog
components used within this implementation should be portalled to the body given their similar implementation style.
from comm-time.
Within this minimal repro, I can see that the layout shift isn't occurring. So while above I initially thought this could be a portal
issue, I don't believe that is the case anymore.
I'm thinking this likely has something to do with my styling or the way the data is being populated in the current implementation. There's also a preventScroll
prop that can be used on the Root
of the dialog that may help with this. Will have to test within the normal dev environment.
from comm-time.
I've reached out to help within Huntabyte's discord for this because the idea with preventScroll didn't help nor did messing with individual transitions
from comm-time.
After some reflection, it may be better to utilize the Sheet
components for the sharing time entries and viewing notes. I'm gonna play with this idea a little bit in a new issue.
from comm-time.
Related Issues (20)
- Bug Fix: 'Time Table Actions' not closing when transitioning to 'edit' route
- Cleanup: Remove unused share route
- Rework: 'Edit Time Entry' Route
- Rework: 'Notes' Dialog HOT 1
- Cleanup: Toasts for Login
- Feat: Error Page
- Cleanup: Overall
- Feat: Text Editor Buttons HOT 2
- Bug: 'Time Table' Filtering HOT 1
- Feat: 'Admin' Route HOT 1
- Bug: 'Shared' Route - 'Notes Dialog'
- Rework: Viewing Notes and Sharing Entries UI
- Rework: Add Toast to 'Delete Time Entry' Action
- Alpha Testing
- Update README with relevant project and stack details
- Add page titles for each page
- Rework: `Editor` Buttons
- Rework: `TimeTable`
- Rework: `EditTimeEntry` & `TimeEntry` Form HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from comm-time.