Code Monkey home page Code Monkey logo

Comments (4)

pglezen avatar pglezen commented on August 17, 2024

+1
Since JJWT is a library that ideally would be referenced from a wide variety of execution contexts (JEE, standalone, Spring containers, OSGi containers (ok, OSGi doesn't have this problem)), dependencies should be kept to an absolute minimum. If SLF4J was embedded everywhere in JJWT, I would wipe my brow and bear it. But it seems that by simply (pun intended) logging to the JUL Loggers in the one class mentioned by @arvinsuresh , we could avoid yet another dependency.

Full disclosure: I worked with Arvin for a few months last Spring where we used JJWT. So my post stems from a common issue we both experienced on the same project task. But I expect this issue to reoccur with other teams I encounter. I'm a big fan of JJWT and nixing this extra dependency would really help to spread it.

from jjwt.

lhazlewood avatar lhazlewood commented on August 17, 2024

Yeah, this was an artifact from a copy-n-paste operation long ago. I'm happy to remove it since it's not prolific in JJWT and only used in one class. Thanks for the issue!

from jjwt.

theblang avatar theblang commented on August 17, 2024

+1
Android users try to stay under a function limit of 65k, so removing unnecessary dependencies would be nice.

from jjwt.

lhazlewood avatar lhazlewood commented on August 17, 2024

Resolved by PR #41. Will be released in 0.6.

from jjwt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.