Comments (4)
That's a good idea. Would you consider doing a PR for that? I'm not doing much Scala lately and don't really have time for this project.
from jwt-scala.
Can't we just remove the need to rely on BouncyCastle and have the library rely on what is already installed? That way, the library leaves the decision of which provider to use completely up to the user's app.
If this is an acceptable solution, I don't mind submitting a PR for this issue.
from jwt-scala.
How would you do that? Not sure how you can just import something you're not even sure is present. Also, ensure the API is the correct one.
I'm also concerned about the migration path for existing users.
from jwt-scala.
See: #126 for an initial pass. I've already tested it for my use case and it works well.
Essentially, we place the onus on the user to give a provider that meets their use case. If the user does not provide a sufficient provider for the algorithm they choose, then it will fail as expected. Otherwise, they can provide BouncyCastle or some other provider on their own if needed.
Edit: I should add, for most algorithms in the library (except two), the stock JCE provider worked perfectly fine.
In my case, I needed a FIPS-complaint provider which I provided at application boot time via config. However, this library decided to ignore the recommendation of my application, inserting its own provider and thereby weakening the security of the entire app.
I agree there is essentially a contract change which will require a user decision, but IMO the tradeoff is worth it in the long term. Would love to hear your thoughts.
from jwt-scala.
Related Issues (20)
- Add zio-json usage documentation
- com.fasterxml.jackson.databind.JsonMappingException: Scala module 2.11.4 requires Jackson Databind version >= 2.11.0 and < 2.12.0 HOT 10
- 9.1.1 changelog? HOT 2
- zio-json partially missing in the docs
- com.fasterxml.jackson.databind.JsonMappingException: Scala module 2.11.4 requires Jackson Databind version >= 2.11.0 and < 2.12.0 HOT 2
- Why does JwtCirce.decode lead to java.time.Clock validating the expiration? HOT 3
- [Question] Support for Base64 url encoded keys HOT 1
- [Question] Lookup the algorithm from the token
- fix scala-js build HOT 5
- Ed25519 is not the correct JSON Web Algorithm name
- parseKey does not work with keys stored in AWS secrets manager
- Version 9.4.0 is not compatible with Scala 3.2.2 HOT 6
- New release? HOT 3
- scala.js compatibility
- Incorrect Regex for JTI and ISS
- Play 3.x support for `jwt-play` HOT 2
- Scala3 Support for jwt-play HOT 1
- scala-jwt 9.4.5 contains a major breaking change HOT 1
- com.fasterxml.jackson.databind.JsonMappingException: Scala module 2.14.3 requires Jackson Databind version >= 2.14.0 and < 2.15.0 - Found jackson-databind version 2.15.0 HOT 1
- JWKS? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jwt-scala.