Code Monkey home page Code Monkey logo

Comments (14)

pauldijou avatar pauldijou commented on July 28, 2024 10

@daniel-harrison It is fully decoupled actually, like 100%. I'm just having troubles with SBT. It looks like as soon as I enable cross-compilation, it will cross compile all projects with the same Scala versions even if they are different in their respective settings. I don't understand at all...

As we can see here, I only enable 2.12 for some projects and not the Play ones. But still, trying to compile Play in 2.12

Right now, I'm considering dropping Play support from the project (already published versions will stay on Maven obviously) and putting it back when they support Scala 2.12.

from jwt-scala.

pauldijou avatar pauldijou commented on July 28, 2024 1

Done in 0.10.0

from jwt-scala.

pauldijou avatar pauldijou commented on July 28, 2024

I wanted to do it last weekend but Play does not support 2.12 yet and I didn't have time to dive into my SBT build. So either I will find some time at some point, or wait for Play framework, or a nice PR will pop out.

from jwt-scala.

pauldijou avatar pauldijou commented on July 28, 2024

I gave it a try just now and pushed the resulting work but I couldn't find a way to properly isolate Play framework projects. Every single time I try to publish, SBT will try to build them using Scala 2.12. So frustrating as all other projects compile just fine and all tests are green...

from jwt-scala.

vaclavsvejcar avatar vaclavsvejcar commented on July 28, 2024

The truth is that I've completely forgotten about the Play dependency in your library. Maybe the easier way will be just wait till Play is be released for 2.12. Version 2.5.10 has been released few days ago, however, still no 2.12 support. I'll try to research the current state of Play 2.5.x for Scala 2.12. Anyway, thanks for your effort.

from jwt-scala.

vaclavsvejcar avatar vaclavsvejcar commented on July 28, 2024

So according to the discussion I initiated on r/scala it seems that there won't be any 2.12 support for 2.5.x Play Framework and 2.6.0 ETA is March-April 2017 (source: Play Framework Roadmap).

from jwt-scala.

ngbinh avatar ngbinh commented on July 28, 2024

it's suck that this is the only thing blocking us from upgrading to 2.12 now.

from jwt-scala.

daniel-harrison avatar daniel-harrison commented on July 28, 2024

I was able to get this building for 2.12 as made the mistake of moving things to 2.12 chasing the rabbit. Had to use snapshot deps but it seems odd that play ETA won't be out for months and no 2.12, J. I'm "only" using the jwt-json4s-jackson libraries. Is there any way this could be decoupled from play maybe or is this an architectural desire?

from jwt-scala.

jurisk avatar jurisk commented on July 28, 2024

dropping Play support from the project and putting it back when they support Scala 2.12

This seems as a pragmatic solution.

from jwt-scala.

daniel-harrison avatar daniel-harrison commented on July 28, 2024

@pauldijou Cool decoupled, I'm with @jurisk voting to drop play till they support; as would prefer to be on a supported 2.12 branch. Thanks for the library BTW, did everything advertised and apart from 2.12 ;) worked great.

from jwt-scala.

vaclavsvejcar avatar vaclavsvejcar commented on July 28, 2024

Hi @pauldijou , just for your info, Play Framework team just released milestone version of Play 2.6 for Scala 2.12

from jwt-scala.

pauldijou avatar pauldijou commented on July 28, 2024

Play support is back in 0.11.0

from jwt-scala.

vaclavsvejcar avatar vaclavsvejcar commented on July 28, 2024

cool, thank you 👍

from jwt-scala.

pauldijou avatar pauldijou commented on July 28, 2024

Hey folks, if any of you have too much free time, I'm looking for feedback on this PR : #45

from jwt-scala.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.