Javascript is precompiled, but rails thinks it isn't about requirejs-rails HOT 9 CLOSED

Discovered the issue. In RequirejsHelper#_javascript_path, the name is being passed as app; the digests manifest has it stored as app.js. If I tack on .js within that function, everything works correctly. So I think either that function needs to be updated, or Requirejs::Rails::Config#module_name_for needs to return mod['include']+.js in the almond case.

from requirejs-rails.

I'll see if I can repro from this description. Note that the gem dynamically adds the contents of rjs_manifest.yml to the Sprockets manifest at runtime, so there's no need or effect to having in manifest.yml.

from requirejs-rails.

AH! You're using almond? So presumably you're hitting this via _almond_include_tag then? If not, what's the stack trace look like when you're seeing this problem in _javascript_path?

A number of callers of _javascript_path guard for the .js case and amend name. Looks like I need to reconsider how that whole business works; looks a tad scattershot in hindsight.

from requirejs-rails.

Yep exactly. From going through the source, I think _almond_include_tag is the only case where the .js hasn't been appended.

from requirejs-rails.

Ran into that today without using almond: This happens not only in _almond_include_tag, but also in resolving paths for modules spec: https://github.com/jwhitley/requirejs-rails/blob/v0.8.2/app/helpers/requirejs_helper.rb#L55.

from requirejs-rails.

@jou, thanks for the report. None of the apps (either test or "real") that I have exhibit the problem as you've described it. I'd like to write a failing test for your case and get it fixed, but it's not immediately clear what the failure mode for your case is. Can you provide any tips on your configuration (e.g. requirejs.yml settings, etc.) that may be triggering this? Thanks!

from requirejs-rails.

I created a Rails app that exhibit the problem: https://gist.github.com/2834831 (clone it via git to see the contents, it's a complete Rails app).

It's doing a layered build, same as described in the README.

When you do a rake assets:precompile and then start it in production environment with RAILS_ENV=production rails s, it throws ActionView::Template::Error (appcommon isn't precompiled).

The problem is that requirejs_include_tag tries to resolve the path to the compiled assets for the defined modules in requirejs.yml to put them in the "paths" attribute of RequireJS config. But it does so without appending .js and Rails' asset helper gets confused.

I worked around by patching RequirejsHelper with https://gist.github.com/2834968. Maybe it's a better idea to appending .js if necessary to _javascript_path

from requirejs-rails.

No solution for this problem yet? :(

from requirejs-rails.

Hopefully we'll have almond support in the near to medium future. Please use #159 for further discussion.

from requirejs-rails.