Code Monkey home page Code Monkey logo

Comments (6)

jwhitley avatar jwhitley commented on August 10, 2024

I'm not following your request. Can you be more specific?

Currently a build using requirejs-rails (built via rake assets:precompile) produces correctly hashed asset filenames. These will be used by requirejs_include_tag in production. As of v0.6, requirejs_include_tag will also emit a require.js paths config in production to ensure that require('foo') will hit the hashed filename (e.g. foo-123456abcde.js).

What are you looking for beyond this functionality?

from requirejs-rails.

jwhitley avatar jwhitley commented on August 10, 2024

Hrm, although I now note that the above isn't really clearly called out in the README right now. Folks who've been following along for awhile have picked that up from the CHANGELOG and/or announcements on the requirejs group. I'll update the docs on this point.

from requirejs-rails.

pctj101 avatar pctj101 commented on August 10, 2024

Oh I see. Thanks for catching me up on this and the note to use assets:prcompile.

from requirejs-rails.

jwhitley avatar jwhitley commented on August 10, 2024

Reopening to track docs improvement for 1.0 release.

from requirejs-rails.

jeromegn avatar jeromegn commented on August 10, 2024

Here's one thing to note (took me over a day to debug this...):

RequireJS uses the data-main property of its script that to know which module to "require" once the file has been loaded. With hashed filenames, it attempts to load something like "main-980as089asd98f7a2". Since the module is really called "main", it doesn't require it.

This pretty much fails silently. I would advise fixing this method: https://github.com/jwhitley/requirejs-rails/blob/master/app/helpers/requirejs_helper.rb#L10-24 not to keep the hash in the filename.

Here's a quick fix that doesn't require forking the gem:

<%= requirejs_include_tag "main" do
      {"main" => "main"}
    end
%>

from requirejs-rails.

carsomyr avatar carsomyr commented on August 10, 2024

@jeromegn I think that the recent changes on master fixed this, with data-main no longer being used.

from requirejs-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.