Missing keywords: data and type families, pattern synonyms, deriving via about language-haskell HOT 4 CLOSED

Okay, I think I got them all now?

Thanks for the diligent reporting!

from language-haskell.

Excellent, the addition of highlighting for type families and pattern synonyms is very much appreciated. Thanks!

The code for highlighting type families should be extended to work with data families too:

Changing data to type in the above makes the highlighting work properly, so it seems it's just a case of allowing the data keyword.

For pattern synonyms, multiple patterns are not currently highlighted properly:

If that's annoying to fix then no big deal of course. (I'm not sure why False is not getting highlighted properly there; I've reported that separately in #122.)

As seen in this screenshot, it would also be nice to support the keywords for the three built-in deriving strategies: stock, newtype and anyclass.

Finally, the highlighting for the single-line deriving via that is currently implemented seems to always require parentheses:

Sorry for including all this in this single ticket; I can split it out into other issues if you would prefer.
I have a few other bugs to report, but let me be clear that I am very appreciative of the effort you have put in, and don't in any way mean to discourage. Thanks again.

from language-haskell.

I realise now that defining multiple patterns at once in a pattern synonym is actually already supported, but it's #122 that makes it look otherwise.

from language-haskell.

All the keywords mentioned in this ticket are now supported, so I'm closing this issue.

Some highlighting issues still remain, e.g. type families aren't correctly highlighting types (highlighting them as values instead). This is being tracked separately in #133.

from language-haskell.