Code Monkey home page Code Monkey logo

Comments (5)

JustinBeckwith avatar JustinBeckwith commented on June 7, 2024

Greetings! What type of environment are you trying to support? const is supported by any reasonably modern version of node or the browser:

from retry-axios.

valgussev avatar valgussev commented on June 7, 2024

Hi @JustinBeckwith I believe an explanation can be found here https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify. So all the applications which are built on top of the older create-react-app version or any similar environment will fail to build without library being transpiled into es5. Please correct me if I'm wrong.

from retry-axios.

 avatar commented on June 7, 2024

@JustinBeckwith Anything that is blocking the merge of this PR #38 ?

from retry-axios.

JustinBeckwith avatar JustinBeckwith commented on June 7, 2024

I'm a little concerned about down-leveling compilation that far, as it does come at a perf cost - especially as we're getting closer to things like broad support for native async/await and such.

Reading that link you shared - it feels like the answer is to upgrade to a recent version of react-scripts, no? Just want to make sure we're making a change like this for the right reasons :)

from retry-axios.

 avatar commented on June 7, 2024

Yes, I see your point @JustinBeckwith. Another solution is to create two different builds (es6 and es5).

We ended up downgrading to [email protected] which was in ES5.
So I think we can close the issue and PR?

from retry-axios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.