Comments (5)
Greetings! What type of environment are you trying to support? const
is supported by any reasonably modern version of node or the browser:
from retry-axios.
Hi @JustinBeckwith I believe an explanation can be found here https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify. So all the applications which are built on top of the older create-react-app version or any similar environment will fail to build without library being transpiled into es5. Please correct me if I'm wrong.
from retry-axios.
@JustinBeckwith Anything that is blocking the merge of this PR #38 ?
from retry-axios.
I'm a little concerned about down-leveling compilation that far, as it does come at a perf cost - especially as we're getting closer to things like broad support for native async/await and such.
Reading that link you shared - it feels like the answer is to upgrade to a recent version of react-scripts
, no? Just want to make sure we're making a change like this for the right reasons :)
from retry-axios.
Yes, I see your point @JustinBeckwith. Another solution is to create two different builds (es6 and es5).
We ended up downgrading to [email protected]
which was in ES5.
So I think we can close the issue and PR?
from retry-axios.
Related Issues (20)
- Exponential Retry should be configurable. By default is 1000ms HOT 2
- Add "PATCH" operations to the httpMethodsToRetry HOT 2
- Question re: max retry delay HOT 3
- Dependency Dashboard
- A jitter option would be a nice feature HOT 1
- Stalls on third attempt HOT 1
- Retry on non-error codes HOT 1
- Question: Network shutdown case
- Problem with 3.0.0 HOT 6
- This lib does not work no node_threads HOT 12
- BUG: noResponseRetries > 0 not retried
- v3 Breaks Typescript Build HOT 6
- v3 no longer supports browser usage?
- onRetryAttempt how to change baseUrl dinamically while retrying HOT 2
- Question: Exponential Backoff execution times HOT 1
- Import fails after Jest v28 update (Cannot use import statement outside a module) HOT 5
- Failed to execute 'setRequestHeader' on 'XMLHttpRequest'
- retry-axios doesn't work with latest axios release v1.1.3 HOT 4
- Also supports CommonJS HOT 1
- Cannot find module 'retry-axios' or its corresponding type declarations HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from retry-axios.