Comments (8)
Saying "have you read this" is kind of being a turd
Thanks for the feedback. I am sorry man, really didn't want to come across like that.
My addition to this ticket was meant in a neutral-friendly way, therefore also the ":)". It certainly was meant to be a productive contribution: it really appeared to me (based on the communication in here so far) as if you might have missed a specific problem description -- the one I have quoted.
Missing something happens to all of us. All I wanted is to ask and make sure that it's not just a simple misunderstanding. I got the impression that you missed it because you didn't comment on it and also suggested that you may not see/understand the specific problem(s) reported. Based on your "so I can really understand". Again: no blame, no stress -- all of this easily happens in a ticket like this (also because this bug report mixes two issues and does not have a precise title); and I wanted to help us align on a problem and/or acknowledge a problem description (which is one of the most important parts in my opinion for inviting contributors: define a problem to be solved rather well -- together).
from retry-axios.
Loud and clear. Sorry if I was crass - I catch a lot of flack in issue trackers, and appreciate the clarification! I completely understand what you mean now, and apologize for being short.
On the issue itself - totally understand what folks are saying. What I was trying to get across is that I don't believe there are tests which dig into the specific timing of the retries. I'd like to avoid having a patch floated that "fixes" the issue without having a fairly in-depth suite of tests that specifically cover backoff expectations. If someone submitted a fix today for this, it's likely all the tests we have in place would just pass with no changes. After that, it's very likely that the next patch breaks it (or you know, I accidentally break it).
Thanks for bearing with my being grumpy.
from retry-axios.
@JustinBeckwith would you accept PRs addressing this and other issues?.
from retry-axios.
👋 absolutely! Would love PRs, especially ones that come with tests so I can really understand what was going wrong :)
from retry-axios.
about
so I can really understand what was going wrong :)
Have you read this? :)
it does not wait in the first attempt, this is because currentRetryAttempt is initially set to 0 instead of 1
Between the first attempt (attempt 0) and the first retry (attempt 1) there should be a non-zero delay. With the current code there isn't: there is no delay. That's one of two problems that @sk- was pointing out :).
((Math.pow(2, config.currentRetryAttempt!) - 1) / 2) * 1000;
is 0 for currentRetryAttem
being 0.
Same for the linear one: delay = config.currentRetryAttempt! * 1000;
is 0 for ...
from retry-axios.
👋 Saying "have you read this" is kind of being a turd - please don't be a turd. There were some changes here recently which may have resolved the issue. If folks are interested, I'd be happy to take a PR (as mentioned above), but I'm unlikely to dig in here soon.
from retry-axios.
Thank you for the kind words, Justin! Thanks for being vulnerable. I totally see where you're coming from with "I catch a lot of flack in issue trackers" -- and I am glad that we figured this out w/o feeling bad after all. Feels good that we talked through that; thanks for taking a moment to type up this response. I love open source also because of interactions like this.
from retry-axios.
Between the first attempt (attempt 0) and the first retry (attempt 1) there should be a non-zero delay. With the current code there isn't: there is no delay.
attempt to fix that in #163
from retry-axios.
Related Issues (20)
- Exponential Retry should be configurable. By default is 1000ms HOT 2
- Add "PATCH" operations to the httpMethodsToRetry HOT 2
- Question re: max retry delay HOT 3
- Dependency Dashboard
- A jitter option would be a nice feature HOT 1
- Stalls on third attempt HOT 1
- Retry on non-error codes HOT 1
- Question: Network shutdown case
- Problem with 3.0.0 HOT 6
- This lib does not work no node_threads HOT 12
- BUG: noResponseRetries > 0 not retried
- v3 Breaks Typescript Build HOT 6
- v3 no longer supports browser usage?
- onRetryAttempt how to change baseUrl dinamically while retrying HOT 2
- Question: Exponential Backoff execution times HOT 1
- Import fails after Jest v28 update (Cannot use import statement outside a module) HOT 5
- Failed to execute 'setRequestHeader' on 'XMLHttpRequest'
- retry-axios doesn't work with latest axios release v1.1.3 HOT 4
- Also supports CommonJS HOT 1
- Cannot find module 'retry-axios' or its corresponding type declarations HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from retry-axios.