Comments (3)
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋
Welcome to the Jupyter community! 🎉
from jupyterlab_server.
The parsing to blame is the one in the connector: https://github.com/jupyterlab/jupyterlab/blob/master/packages/services/src/setting/index.ts#L63
from jupyterlab_server.
The parsing to blame is the one in the connector: https://github.com/jupyterlab/jupyterlab/blob/master/packages/services/src/setting/index.ts#L63
I responded on the PR, but copying it here too. I think it would be better if the server did not send nonstandard JSON at all (for example, it could send the setting just as raw text to be interpreted as JSON5 on the frontend). If we send nonstandard JSON in response to a settings request, it breaks the expectation of the rest api that the response is valid JSON.
from jupyterlab_server.
Related Issues (20)
- 2.16.0: pytest is failing HOT 9
- 2.16.4: sphinx fails because incorrect path to app-config.rst and `reference target not found` sphinx warnings HOT 6
- test_data in the main package HOT 5
- Watch mode broken
- Update to latest `openapi-spec-validator`
- remove MathJax page config options HOT 1
- jupyterlab_server fails when allowed_extensions_uris is set HOT 1
- page_config.json should support json5 HOT 2
- Improving page load time HOT 4
- 2.20.0: pytest is failing in `tests/test_process.py::test_process_app` unit HOT 1
- 2.22.0: pytest is failing HOT 11
- 2.22.0: phinx warnings `reference target not found`
- Support for openapi-core-0.17* HOT 3
- Add repository url to extension info HOT 1
- Unable to Navigate Notebooks via URL: 'Path Not Found' Error HOT 3
- Zero length page_request.json throws exception HOT 1
- Two tests of jupyterlab failed with 2.27.0 HOT 2
- pre-commit setup fails on Python<3.10 due to `repo-review[cli]` HOT 1
- Tests fail if `notebook_shim` is installed
- Remove the input prompt from commands copied from the documentation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jupyterlab_server.