Comments (8)
@kenjioman I think this issue is the same as your first point in #51, but the replies by @ian-r-rose sound like maybe he didn't quite understand what you were describing.
To be clearer for the devs, the problem is this:
You can see that after you enter edit mode of the code cell, clicking on the TOC entries edits the headers, which is probably not what (99% of the time you probably just want to jump around your notebook), and is quite annoying since you then have to go re-evaluate the markdown cell. This is happening with the latest jupyterlab-toc 0.6.0 and jupyterlab 0.35.4.
from jupyterlab-toc.
The problem seems to be on Google Chrome, and I used Firefox to find out that it doesn't happen. It seems like a compatibility issue, but my personal preference for using chrome has disappointed me.
from jupyterlab-toc.
Same problem.
from jupyterlab-toc.
I think #51 is related? (unless things have changed since when I made the last issue, and you are referring to something else xP).
from jupyterlab-toc.
Here's a guess about what is going on (I haven't tried anything out, just browsed the source, so I might be way off):
I think the scrolling behavior happens around:
jupyterlab-toc/src/generators/notebookgenerator/index.ts
Lines 293 to 294 in fdc5154
My guess is that when the notebook is in edit mode (because you are in a code cell), the active cell is changed, but the notebook stays in edit mode. Perhaps to fix this, you need to see if the target cell is a rendered cell, and if it is, switch the notebook to command mode.
from jupyterlab-toc.
Or maybe this is where the markdown cell clicking is handled. Same issue, though - we should probably check to see if the cell is still rendered, and if it is, make sure the notebook is in command mode:
jupyterlab-toc/src/generators/notebookgenerator/index.ts
Lines 217 to 222 in fdc5154
from jupyterlab-toc.
Yes, I believe you are right @jasongrout. Thanks for taking a look.
from jupyterlab-toc.
Thank you @marius311 ! This did capture my original issue, and thanks to all for your continued hard work making this better and better!
from jupyterlab-toc.
Related Issues (20)
- Big wasted space HOT 2
- Falied to install jupterlab-toc HOT 2
- Allow heading numbering to start counting at later Headings and not just Heading 1 HOT 2
- Render cell doesn't show. Jupiter lab 2.2.6 HOT 1
- configuration option for font size HOT 1
- .py file navigation: remove method/class arguments
- Bring focus to
- Side bar is not showing up HOT 1
- An error occurred installing @jupyterlab/toc-extension. HOT 19
- Error while installing @jupyterlab/toc
- Mark this repo as archived HOT 10
- TOC eats up code cells HOT 1
- How to install if I cannot run "jupyter" HOT 4
- Indents for contents HOT 1
- The collapse ticker is missing in the table of contents HOT 1
- provide a new outline of folding , not adaptive but directly masking the titles when it is shrinked
- Keyboard shortcut to show sidebar panel? HOT 1
- An error occurred installing @jupyterlab/toc-extension. HOT 4
- No table of content in jupyter lab 3.0.7 HOT 4
- '@jupyterlab/toc' is not a valid extension HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jupyterlab-toc.