console does not display text/plain alternative for display_data? about jupyter_console HOT 7 CLOSED

This also looks wrong:

[ZMQTerminalIPythonApp] Loading IPython extension: storemagic

from jupyter_console.

It looks like it works with the execute_result message (that generates an Out prompt), but not with display_data:

In [1]: class A():
      :     def _repr_png_(self):
      :         return b'oijoij'
      :     

In [2]: a= A()

In [3]: a
Out[3]: <__main__.A at 0x7f052871f1d0>

In [4]: from IPython.display import display

In [5]: display(a)

from jupyter_console.

well I was against changing it 😉

from jupyter_console.

well, the cause is easy to identify:

1. handle_rich_data is called, which in turn calls handle_image and then returns True. when returning True, text/plain isn’t used.
2. handle_image_PIL checks if the mimetype is PNG or SVG and returns if not, without doing anything.

we should make handle_image return True/False depending on if its delegated function can handle it the format.

AGAIN a bug exposed by having SVG! this is so useful!

from jupyter_console.

Thanks, well worked out. I've just opened #77 for it, and then noticed that you've done a fix as well. You've opened a PR against your own fork of the repo, though ;-)

from jupyter_console.

whoops

from jupyter_console.

AGAIN a bug exposed by having SVG! this is so useful!

More "(ab)using users as guinea pigs"... :-)

from jupyter_console.