Code Monkey home page Code Monkey logo

Comments (14)

dalogsdon avatar dalogsdon commented on June 22, 2024

We haven't seen this issue in our testing. The normal behavior is to push the cells out of the way. Can you post either a screenshot or a notebook that reproduces the issue?

from dashboards.

jtyberg avatar jtyberg commented on June 22, 2024

Actually, the problem only seems to occur with cells that contain images/plots. The cell boundaries do not always "contain" the image. I didn't even realize that I did not size the cell correctly. I kinda wish it wouldn't let me do that.

large_overlap

from dashboards.

parente avatar parente commented on June 22, 2024

Maybe if we reversed the original thinking and clipped at the grid cell boundaries it would be less surprising? The problem then is that the notebook author can't always predict what the max size of a cell will be (e.g., table) and overflow is beneficial in that case.

from dashboards.

parente avatar parente commented on June 22, 2024

Maybe indicate where cell ends and overlap begins? Maybe revisit if clipping or scrolling within the cell is possible?

Investigation required.

from dashboards.

jhpedemonte avatar jhpedemonte commented on June 22, 2024

The main reason we don't hide overflow of cells is due to menus. With overflow:hidden, menus are clipped at that bottom of the cell. Side effect is that some other elements also leak out, as seen above.

from dashboards.

jhpedemonte avatar jhpedemonte commented on June 22, 2024

One option: make borders of cells appear above cell contents, as seen below:

screen shot 2015-10-27 at 11 27 10 am

from dashboards.

jhpedemonte avatar jhpedemonte commented on June 22, 2024

Second option: use JavaScript to calculate the height of the cell content, and don't allow cell to be sized any smaller. This might be frustrating to users, though, since it removes some control -- it's possible a user would want there to be overflow.

from dashboards.

jhpedemonte avatar jhpedemonte commented on June 22, 2024

Also, it should be noted that when first going into dashboard view (no previous dashboard data) and when doing a show all, the cell is properly sized to contain the cell contents as they currently exist. So the only way to get overflow are: (1) the user resizes smaller than content, as Justin did in screenshot above; (2) there is a widget (such as a menu) which increases in height.

from dashboards.

jtyberg avatar jtyberg commented on June 22, 2024

Actually, I've found that during initial sizing of cell, to make it larger, the content can leak outside the cell boundary, even if I only ever increase the cell size. For example, when increasing in one direction, say width, an image within the cell increases in both width and height. Since the aspect ratio of the bounding box is not constrained, it's rather easy to get overlap when only making the cell bigger.

from dashboards.

parente avatar parente commented on June 22, 2024

I like option 1 for its simplicity in comparison to 2.

from dashboards.

dalogsdon avatar dalogsdon commented on June 22, 2024

when first going into dashboard view (no previous dashboard data) and when doing a show all, the cell is properly sized to contain the cell contents as they currently exist

When sizing a cell, we set a temporary width on the cell to cause text cells to automatically wrap after a certain point so not all text cells take the full width. This causes images larger than that size to be sized smaller than their true size. Resizing these images to be larger could then cause an overflow.

from dashboards.

dalogsdon avatar dalogsdon commented on June 22, 2024

PR #66 resolves this using option 1, showing cell borders always.

from dashboards.

parente avatar parente commented on June 22, 2024

@jtyberg give it a whirl and see if it's good enough or not.

from dashboards.

parente avatar parente commented on June 22, 2024

Closing. Can reopen if it's not good enough in practice.

from dashboards.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.