Syntax highlighting about sparkmagic HOT 10 CLOSED

Scala support is in CodeMirror through this file, clike.js: https://github.com/codemirror/CodeMirror/blob/master/mode/clike/clike.js

However, when I set the mode to clike for Scala, I don't get correct highlighting/text editing behavior (none of the correct keywords are highlighted, and default indentation is incorrect unless I put a semicolon at the end of all my lines). Going to keep investigating.

from sparkmagic.

Python taken care of through #104

from sparkmagic.

In my testing, Scala isn't working even if I set the codemirror mode to "clike" and the MIME type to text/x-scala. For some reason CodeMirror isn't "getting" that what I type in is supposed to be Scala code and is instead applying some very simple, stupid syntax highlighting to it (i.e. only highlighting equals signs and integer literals). Can keep looking at this later.

from sparkmagic.

Hey @msftristew, any updates for this?

from sparkmagic.

Scala and Python syntax highlighting are both working great. I haven't tested out SQL but it should be easy (@alope107's solution should be fine here)

from sparkmagic.

There's an issue. See ipython/ipython#7548

It looks like only cell magics trigger magics syntax highlighting. I don't think that syntax-highlighted line magics are supported. This means that our SQL and Hive commands need to be %%sql and %%hive in order for syntax highlighting to kick in -- %sql and %hive won't work.

from sparkmagic.

Let's go with that for now and we'll investigate line magics in parallel.

from sparkmagic.

Arguably all of the "magics" in our Spark kernel are cell magics, not line magics. So it breaks with convention less if we move to a model where %%sql, %%hive, %%config, etc. are the "normal" way to call things.

from sparkmagic.

Still need to do this :(

from sparkmagic.

So, I have a branch going (kerneljs) which is supposed to fix SQL syntax highlighting. As it stands, on my Windows machine, SQL syntax highlighting works for the first cell but fails with an error message in the console for the rest.

I think this PR to jupyter/notebook (which hasn't made it into an official release yet) is supposed to fix this issue? Maybe? I don't know.

from sparkmagic.