junos_install_os:Better Handling of error message needed when junos install fails. about ansible-junos-stdlib HOT 5 CLOSED

regress@richie> show version
Hostname: richie
Model: m120

Manual test result:
Configuration not compatible with image error on device.

regress@richie> request system software add jinstall-11.4R10.1-domestic-signed.tgz
NOTICE: Validating configuration against jinstall-11.4R10.1-domestic-signed.tgz.
NOTICE: Use the 'no-validate' option to skip this if desired.
Checking compatibility with configuration
Initializing...
Using jbase-12.1R8
~
~
/config/rescue.conf.gz:376:(37) syntax error at 'persist-groups-inheritance'
[edit system commit]
'commit persist-groups-inheritance;'
syntax error
[edit system]
'commit'
warning: statement has no contents; ignored
Validation failed
WARNING: Current configuration not compatible with /var/home/regress/jinstall-11.4R10.1-domestic-signed.tgz

from ansible-junos-stdlib.

From the logs:

2014-04-28 16:46:47,892:richie:Starting the software upgrade process: /var/tmp/jinstall-11.4R10.1-domestic-signed.tgz
2014-04-28 16:46:47,892:richie:computing local checksum on: /var/tmp/jinstall-11.4R10.1-domestic-signed.tgz
2014-04-28 16:46:48,984:richie:cleaning filesystem ...
2014-04-28 16:47:01,479:paramiko.transport:starting thread (client mode): 0x9c6e10cL
2014-04-28 16:47:01,511:paramiko.transport:Connected (version 2.0, client OpenSSH_5.9)
2014-04-28 16:47:01,525:paramiko.transport:kex algos:[u'ecdh-sha2-nistp256', u'ecdh-sha2-nistp384', u'ecdh-sha2-nistp521', u'diffie-hellman-group-exchange-sha256', u'diffie-hellman-group-exchange-sha1', u'diffie-hellman-group14-sha1', u'diffie-hellman-group1-sha1'] server key:[u'ssh-rsa', u'ssh-dss', u'ecdsa-sha2-nistp256'] client encrypt:[u'aes128-ctr', u'aes192-ctr', u'aes256-ctr', u'arcfour256', u'arcfour128', u'aes128-cbc', u'3des-cbc', u'blowfish-cbc', u'cast128-cbc', u'aes192-cbc', u'aes256-cbc', u'arcfour', u'[email protected]'] server encrypt:[u'aes128-ctr', u'aes192-ctr', u'aes256-ctr', u'arcfour256', u'arcfour128', u'aes128-cbc', u'3des-cbc', u'blowfish-cbc', u'cast128-cbc', u'aes192-cbc', u'aes256-cbc', u'arcfour', u'[email protected]'] client mac:[u'hmac-md5', u'hmac-sha1', u'[email protected]', u'hmac-sha2-256', u'hmac-sha2-256-96', u'hmac-sha2-512', u'hmac-sha2-512-96', u'hmac-ripemd160', u'[email protected]', u'hmac-sha1-96', u'hmac-md5-96'] server mac:[u'hmac-md5', u'hmac-sha1', u'[email protected]', u'hmac-sha2-256', u'hmac-sha2-256-96', u'hmac-sha2-512', u'hmac-sha2-512-96', u'hmac-ripemd160', u'[email protected]', u'hmac-sha1-96', u'hmac-md5-96'] client compress:[u'none', u'[email protected]'] server compress:[u'none', u'[email protected]'] client lang:[u''] server lang:[u''] kex follows?False
2014-04-28 16:47:01,525:paramiko.transport:Ciphers agreed: local=aes128-ctr, remote=aes128-ctr
2014-04-28 16:47:01,525:paramiko.transport:using kex diffie-hellman-group1-sha1; server key type ssh-rsa; cipher: local aes128-ctr, remote aes128-ctr; mac: local hmac-sha1, remote hmac-sha1; compression: local none, remote none
2014-04-28 16:47:01,677:paramiko.transport:Switch to new keys ...
2014-04-28 16:47:01,679:paramiko.transport:Adding ssh-rsa host key for richie: d8f763f039d603350d21f70e06e5c76b
2014-04-28 16:47:01,681:paramiko.transport:Trying discovered key 97fdf2252faec2370d209d7cc02d2095 in /home/regress/.ssh/id_rsa
2014-04-28 16:47:01,777:paramiko.transport:userauth is OK
2014-04-28 16:47:01,812:paramiko.transport:Authentication (publickey) successful!
2014-04-28 16:47:01,820:paramiko.transport:[chan 1] Max packet in: 34816 bytes
2014-04-28 16:47:01,821:paramiko.transport:[chan 1] Max packet out: 32768 bytes
2014-04-28 16:47:01,821:paramiko.transport:Secsh channel 1 opened.
2014-04-28 16:47:01,823:paramiko.transport:[chan 1] Sesch channel 1 request ok
2014-04-28 16:47:09,030:richie:jinstall-11.4R10.1-domestic-signed.tgz: 42188800 / 421774322 (10%)
2014-04-28 16:47:15,869:richie:jinstall-11.4R10.1-domestic-signed.tgz: 84361216 / 421774322 (20%)
2014-04-28 16:47:22,704:richie:jinstall-11.4R10.1-domestic-signed.tgz: 126533632 / 421774322 (30%)
2014-04-28 16:47:29,662:richie:jinstall-11.4R10.1-domestic-signed.tgz: 168722432 / 421774322 (40%)
2014-04-28 16:47:36,487:richie:jinstall-11.4R10.1-domestic-signed.tgz: 210894848 / 421774322 (50%)
2014-04-28 16:47:43,343:richie:jinstall-11.4R10.1-domestic-signed.tgz: 253067264 / 421774322 (60%)
2014-04-28 16:47:51,695:richie:jinstall-11.4R10.1-domestic-signed.tgz: 295256064 / 421774322 (70%)
2014-04-28 16:47:59,630:richie:jinstall-11.4R10.1-domestic-signed.tgz: 337428480 / 421774322 (80%)
2014-04-28 16:48:06,497:richie:jinstall-11.4R10.1-domestic-signed.tgz: 379600896 / 421774322 (90%)
2014-04-28 16:48:13,373:richie:jinstall-11.4R10.1-domestic-signed.tgz: 421774322 / 421774322 (100%)
2014-04-28 16:48:13,487:paramiko.transport:[chan 1] EOF sent (1)
2014-04-28 16:48:13,490:paramiko.transport:EOF in transport thread
2014-04-28 16:48:13,491:richie:computing remote checksum on: /var/tmp/jinstall-11.4R10.1-domestic-signed.tgz
2014-04-28 16:48:20,271:richie:checksum check passed.
2014-04-28 16:48:20,271:richie:Unable to install the software
2014-04-28 16:48:20,386:richie:pausing: 10
2014-04-28 16:48:30,396:richie:process completed OK.

from ansible-junos-stdlib.

OK, it appears that we need to trap the occurrence of a software upgrade validation failure. Thank you for this report.

from ansible-junos-stdlib.

closing; this should also been fixed as a result of other issue #9

from ansible-junos-stdlib.

Issue resolved:

Verified with an incorrect image;
failed: [asthra] => {"changed": true, "check_mode": false, "failed": true, "ver": {"has": "12.1X44-D10", "should": "13.2R4.6"}}
msg: Unable to install the software: WARNING: Package jinstall-ex-4200-13.2R4.6-domestic-signed is not compatible with this system.
WARNING: Please install a supported package (junos-juniper-*.tgz).

FATAL: all hosts have already failed -- aborting

PLAY RECAP ********************************************************************
to retry, use: --limit @/home/regress/softwr.retry

asthra : ok=1 changed=0 unreachable=0 failed=1

from ansible-junos-stdlib.