Comments (4)
You can stream data with websockets, but not with regular HTTP with Mux.
That's because serve(app)
expects a function that goes HTTP.Request -> HTTP.Response
and HTTP.jl
expects the body of the response to be a Vector{UInt8}
. Now, you can get a vector like that from an IOBuffer or by memory mapping some IO source, but I don't think you'll be able to make HTTP.jl wait until the buffer is closed.
If websockets don't suit your need, you could open an issue or PR with HTTP.jl, I don't think it's unreasonable that the response body could be Union{<:IO, Vector{UInt8}}
.
from mux.jl.
@cmcaine This isn't an invalid ticket and WebSockets is not required to stream a response. There are reasons to want to stream a response. Here are the complications. First, the reason why HTTP.Response
uses Vector{UInt8}
is that it's pre-rendering the results in order to get the Content-Length
header. This is a design choice for HTTP.Response
. A more nuanced design choice for HTTP.Response
would be to have the body
be an object that one can print
. HTTP could decide to have a buffer size of 16k or something, and use print(buffer, obj)
to fill that buffer. If the printing terminates before the buffer is full, it could send the buffer. Alternatively, if the buffer fills before the printing has finished, HTTP could use chunked transfer encoding to send that chunk, and then send further chunks as needed, with a final chunk designating that the stream has complete.
The design of higher-level libraries should abstract away this design choice. I would accept for the content body any object that is printable (perhaps using show(io, mimetype, obj)
if you know in advance what the mimetype is.
I made a ticket over at HTTP. JuliaWeb/HTTP.jl#653
from mux.jl.
I think this is an invalid ticket for Mux because, as I said earlier and as you seem to agree, this is an issue for HTTP.jl to decide on.
HTTP.jl does offer a streaming interface, but you can't use it at the same time as the Request and Response objects.
from mux.jl.
HTTP.jl now allows you to provide the body as an IO value, which will then be written to the HTTP.Stream.
To use it from Mux, provide an IO value for the :body key in the response object.
from mux.jl.
Related Issues (20)
- TagBot trigger issue HOT 6
- Add me as a collaborator? HOT 3
- Road to v1 HOT 1
- Error on first request from Firefox HOT 9
- installing Mux v0.7.4 downgrades HTTP v0.9.2 HOT 2
- is Mux.jl an appropriate home for HTTP/Revise glue? HOT 7
- public interface for regression tests? HOT 4
- No :socket key in websocket server object HOT 3
- How to combine method & route ? HOT 1
- `serve` method to integrate websockets broken
- Rest api? HOT 1
- Is there WSS option in Mux v1.0.1? HOT 1
- Precompiling hangs on latest Julia nightly HOT 1
- Feature Request: let splitpath also handle the query intelligently
- Let `response` return a `HTTP.Response` object HOT 6
- Make `http_handler` part of `defaults` and `ws_handler` part of `wdefaults` HOT 1
- WebSockets example in README is slightly broken HOT 2
- Tests broken due to HTTP.jl
- Disable AppVeyor builds
- Tag a version HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mux.jl.