Code Monkey home page Code Monkey logo

Comments (4)

fredo-dedup avatar fredo-dedup commented on June 11, 2024

I changed all references to the ˋlenˋ field of unit ranges which has been removed in julia latest and replaced them with ˋlength(range)ˋ. This was causing the Travis builds to fail.

I also added derivation rules for .+ and .- operators as the use of + and- for Array / Number is deprecated. I had to change ReverseDiffSource for that, bump its version to 0.0.4 and update the REQUIRE file of MCMC (but I did not tag MCMC itself to a new version).

All the tests were ok that way on my PC. I made a PR on METADATA for ReverseDiffSource 0.0.4 last wednesday but it has been been merged as of today apparently. This is causing the Travis test to still fail (it doesn't find the 0.0.4 version of ReverseDiffSource). I am now waiting for this merge to happen to make sure that the build issue that started all this has disappeared.

A temporary fix to have MCMC tests pass should be to run Pkg.checkout("ReverseDiffSource") to force the use of the latest master version.

from klara.jl.

papamarkou avatar papamarkou commented on June 11, 2024

Thanks @fredo-dedup, I just merged your metadata pull request. It should all be fine now. I will check it on my pc too this afternoon, and then will close this issue.

from klara.jl.

fredo-dedup avatar fredo-dedup commented on June 11, 2024

I restarted the Travis build, and tests are passing now. Thanks @scidom for merging the ReverseDiffSource PR.

I am a bit confused about this PR. Was I supposed to merge it myself (do I even have rights to do that ?), or was it ok to wait ?

from klara.jl.

papamarkou avatar papamarkou commented on June 11, 2024

Thanks @fredo-dedup, yes, I can see that the MCMC tests are now passing, so I will close this issue.

My common sense tells me that it is fine to merge metadata updates of your package, but the best person to answer this question is @StefanKarpinski.

from klara.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.