Comments (10)
The error occurs in a test that doesn’t use Metis I think:
https://github.com/JuliaSmoothOptimizers/LimitedLDLFactorizations.jl/blob/main/test/runtests.jl#L173
Here is the error:
test in-place version: Test Failed at /home/runner/work/LimitedLDLFactorizations.jl/LimitedLDLFactorizations.jl/test/runtests.jl:173
Expression: allocs == 0
Evaluated: 48 == 0
from limitedldlfactorizations.jl.
We should try wrap these unit tests in functions. I remember that extra bits where allocated in the tests of Krylov.jl because of the scope of the variables.
@geoffroyleconte May I ask you to have a look?
from limitedldlfactorizations.jl.
It’s odd because the same code in a function run with —track-allocations
reports exactly zero allocations. So it has to do with the tests themselves.
from limitedldlfactorizations.jl.
Ok, so you almost confirmed that the culprit is the global scope.
from limitedldlfactorizations.jl.
In Krylov.jl, the tests are not in functions though … 🤔
from limitedldlfactorizations.jl.
If I update the Project.toml
such that AMD = "=0.5.0"
, I don't have the error anymore.
from limitedldlfactorizations.jl.
In Krylov.jl, the tests are not in functions though … 🤔
I mixed things up... It was for older versions of Julia that I wrapped the Krylov tests in functions.
from limitedldlfactorizations.jl.
Please submit a PR.
from limitedldlfactorizations.jl.
We need to solve the problem first, I don't know why the version 0.5.1 of AMD.jl introduced some allocations.
from limitedldlfactorizations.jl.
I found the culprit.
from limitedldlfactorizations.jl.
Related Issues (15)
- Update README
- Write documentation.
- TagBot trigger issue HOT 13
- Preallocate structure for factorization HOT 2
- Package name HOT 12
- Support for Modified Incomplete Choleksy Decomposition
- Add Support for Matrices with `Int32` and `UInt32` as Indices Vectors HOT 5
- Testing fails on 1.7.0
- Error with the permutation
- Create LimitedLDLFactorization object
- Work with lower triangle instead of strict lower triangle and diagonal
- Issue with the operator \ in Julia 1.2.0 HOT 2
- Support for Unitful sparse arrays? [feature request] HOT 3
- Support multi-vector b
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from limitedldlfactorizations.jl.