Code Monkey home page Code Monkey logo

Comments (10)

dpo avatar dpo commented on May 29, 2024

The error occurs in a test that doesn’t use Metis I think:
https://github.com/JuliaSmoothOptimizers/LimitedLDLFactorizations.jl/blob/main/test/runtests.jl#L173

Here is the error:

test in-place version: Test Failed at /home/runner/work/LimitedLDLFactorizations.jl/LimitedLDLFactorizations.jl/test/runtests.jl:173
  Expression: allocs == 0
   Evaluated: 48 == 0

https://github.com/JuliaSmoothOptimizers/LimitedLDLFactorizations.jl/actions/runs/6542419224/job/17765412771#step:6:138

from limitedldlfactorizations.jl.

amontoison avatar amontoison commented on May 29, 2024

We should try wrap these unit tests in functions. I remember that extra bits where allocated in the tests of Krylov.jl because of the scope of the variables.

@geoffroyleconte May I ask you to have a look?

from limitedldlfactorizations.jl.

dpo avatar dpo commented on May 29, 2024

It’s odd because the same code in a function run with —track-allocations reports exactly zero allocations. So it has to do with the tests themselves.

from limitedldlfactorizations.jl.

amontoison avatar amontoison commented on May 29, 2024

Ok, so you almost confirmed that the culprit is the global scope.

from limitedldlfactorizations.jl.

dpo avatar dpo commented on May 29, 2024

In Krylov.jl, the tests are not in functions though … 🤔

from limitedldlfactorizations.jl.

amontoison avatar amontoison commented on May 29, 2024

If I update the Project.toml such that AMD = "=0.5.0", I don't have the error anymore.

from limitedldlfactorizations.jl.

amontoison avatar amontoison commented on May 29, 2024

In Krylov.jl, the tests are not in functions though … 🤔

I mixed things up... It was for older versions of Julia that I wrapped the Krylov tests in functions.

from limitedldlfactorizations.jl.

dpo avatar dpo commented on May 29, 2024

Please submit a PR.

from limitedldlfactorizations.jl.

amontoison avatar amontoison commented on May 29, 2024

We need to solve the problem first, I don't know why the version 0.5.1 of AMD.jl introduced some allocations.

from limitedldlfactorizations.jl.

amontoison avatar amontoison commented on May 29, 2024

I found the culprit.

from limitedldlfactorizations.jl.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.