(nondeterministic) MWE: <div class="highlight highlight-source-julia notranslate p

Actually, this is an easy fix. <div class="highlight highlight-source-diff notrans

<div class="highlight highlight-source-julia notranslate position-relative overflow-auto" dir="auto"

Threading failure with `@batch` about unroot.jl HOT 2 CLOSED

juliahep commented on May 22, 2024

Threading failure with `@batch`

from unroot.jl.

Comments (2)

aminnj commented on May 22, 2024 2

Actually, this is an easy fix.

-Base.getindex(e::Iterators.Enumerate{LazyTree{T}}, row::Int) where T = (row, first(iterate(e.itr, row)))
+Base.getindex(e::Iterators.Enumerate{LazyTree{T}}, row::Int) where T = (row, LazyEvent(innertable(e.itr), row))

and then...

julia> @time @threads for evt in t ; _ = evt.Muon_pt ; end
  0.420194 seconds (24.55 k allocations: 3.460 GiB, 16.40% gc time, 0.00% compilation time)

julia> @time @threads for (i,evt) in enumerate(t) ; _ = evt.Muon_pt ; end
  0.401146 seconds (27.84 k allocations: 3.460 GiB, 16.16% gc time, 4.41% compilation time)

and then we drop polyester.

from unroot.jl.

aminnj commented on May 22, 2024

julia> @time @batch for evt in t ; _ = evt.Muon_pt; end
  0.501378 seconds (149.80 k allocations: 3.466 GiB, 11.44% gc time, 12.94% compilation time)

julia> @time @threads for evt in t ; _ = evt.Muon_pt; end
  0.413486 seconds (24.45 k allocations: 3.385 GiB, 18.05% gc time, 4.27% compilation time)

julia> @time @batch for (i,evt) in enumerate(t) ; _ = evt.Muon_pt ; end
  2.157369 seconds (61.70 M allocations: 8.052 GiB, 56.97% gc time, 4.21% compilation time)

julia> @time @threads for (i,evt) in enumerate(t) ; _ = evt.Muon_pt ; end
  2.276005 seconds (61.57 M allocations: 7.970 GiB, 60.74% gc time, 1.21% compilation time)

Whether we use @batch (with our customization) or @threads, the parallelized enumerate(t) sucks, so I guess this means we can drop @batch/polyester.jl?

And in the future it would be nice if we could get @threads for (i,evt) in enumerate(t) to have the same performance as @threads for evt in t

from unroot.jl.

Recommend Projects