Comments (2)
Well, this means that the probabilities estimators design is wrong. They should NOT have outcome spaces as fields in the first place. Why do they? A probability estimator is entirely agnostic to the outcome space. It only sees counts. It was a wrong decision to have them as fields. In general, we often follow too much of an object oriented approach instead of the more Julian finction based and multiple dispatch. Too often we make things fields of other things, when they should be arguments to functions instead.
In any case, here it is scientifically conceptually clear that the call signature must be
probabilities(o::OutcomeSpace, x)
probabilities(est::ProbEst, o::OutcomeSpace, x)
probabiities(est::ProbEst, counts_or_probabilities)
where the first signature calles RelavtiveAmount
and then calls the second signature. The second signature is a generic implementation that does not depend on est
or probs
and calls either counts
or probabilities
depending on if o
is count-based. So only the third method has speciifc impleentations.
The probabilities estimators don't have a reason to reference an outcome space.
from complexitymeasures.jl.
Agreed. I'll make a PR implenting these changes asap.
from complexitymeasures.jl.
Related Issues (20)
- Dep compatibility issue between ComplexityMeasures (3.0.0) and DynamicalSystems (3.2.3). HOT 10
- ```genentropy``` is broken HOT 1
- Docstring and implementation for Statistical Complexity is wrong HOT 1
- `eachindex` for `Probabilities` is ambiguous HOT 3
- Signature for `Counts` and `Probabilities` docstrings has the wrong type parameter order HOT 3
- Missing deprecation for `OrdinalPatterns{m}(; τ)` HOT 10
- Some documentation issues for CI HOT 2
- The function `lt` in `OrdinalPatternEncoding` isn't actually used HOT 1
- Reproducibility for `OrdinalPatternEncoding` HOT 3
- It shouldn't be possible to construct an empty `CombinationEncoding` HOT 3
- Feature: "distribution entropy" HOT 3
- Feature: bubble entropy (description is WIP) HOT 4
- Feature: "increment entropy" HOT 1
- Feature: "attention entropy"
- `missing_probabilities` HOT 1
- `counts_and_outcomes` for `BubbleSortSwaps` should also accept state space sets
- Syntax with type parameter `{m}` in `OrdinalPatterns` is not harmonious with the rest of the library HOT 8
- Encoding using `Dispersion` is slower than necessary due to manual integration for normal cdf
- Encoding complex-valued data HOT 2
- [Q] How to calculate MI between two vectors? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from complexitymeasures.jl.