Comments (4)
Thanks for the report!
I think this issue comes from ARFFFiles comparing characters to the openquote character in the Parsers.Options
((opts::Parsers.Options).oq
) in order to decide how to proceed with parsing (effectively trying to detect what oq
should be used for the parsing). The issue in Parserss.jl v2.5 is that opts.oq
is now a Parsers.Token
whereas before it was a UInt8
, and so ARFFFiles end up checking c == opts.oq
which in Parsers.jl v2.4 was 0x22 == 0x22
(true) but in v2.5 is 0x22 == Parsers.Token(0x22)
(false), and we then end up taking a different code path in ARFFFiles and eventually hit the error you see.
https://github.com/cjdoris/ARFFFiles.jl/blob/4fa74951f8c1142440c3adfb6b2994414a8ea0d7/src/ARFFFiles.jl#L296
This seems like something we should fix in Parsers.jl. But i'm not yet sure what the best fix will be :)
from parsers.jl.
Also ARFFFiles.jl does not seem to have any test, which is sad. Otherwise we could have added it to the Parsers.jl integration tests to help us make sure not to break it
from parsers.jl.
Lol
julia> 0x22 == Parsers.Token(0x22)
false
julia> Parsers.Token(0x22) == 0x22
true
Okay, we literally just missed some ==
methods -- will put up a PR to fix!
from parsers.jl.
@nickrobinson251 Thanks for the lightning action on this issue.
from parsers.jl.
Related Issues (20)
- Unclear documentation for `getstring` HOT 6
- Documentation for `ReturnCode` is mangled
- Streamline `xparse` interface HOT 1
- Delete the master branch? HOT 1
- Parsers.jl v2.4.1 breaks InlineStrings.jl HOT 1
- Add Integration Tests for downstream packages HOT 2
- Use quotes to disambiguate empty and missing strings
- InlineStrings.jl tests fail on Parsers.jl `main` HOT 3
- Benchmark current main vs. current release
- Re-enable JET
- Parsers reads out of bounds in `checkdelim!`
- quarto build broken on Parsers v2.5.7
- BoundsError for test that parses incorrect UUID HOT 1
- `groupmark` bugs HOT 1
- Automatic tagging disabled HOT 1
- `xparse` changed behavior after #127 (regression?) HOT 1
- Make it easier to modify behavior of `parse` / `tryparse` / `xparse2` HOT 2
- Ensure `decimal` being the same as `delim` is handled consistently
- Buffer Overflow during precompile HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from parsers.jl.