Comments (3)
manadart
commented on May 13, 2024
Thanks for this; it does indeed look like a bug. I'll add a fix for it soon.
Alternatively, if you already have one, feel free to propose it.
from ratelimit.
kingsamchen
commented on May 13, 2024
I proposed a PR to fix this, and your review comments are welcome.
I also added a test case for this issue in case future changes might need a regression test.
FYI: I noticed there are some test-cases failures, they might need some careful examination and fix.
from ratelimit.
manadart
commented on May 13, 2024
Resolved via #31.
from ratelimit.
Related Issues (20)
- Changing rate on the fly HOT 1
- Can I import this package in go-kit, which is MIT licensed? HOT 1
- I believe capacity is broken? HOT 1
- Does method ratelimit.go , Bucket.abjust has a bug ? HOT 2
- Lock-free implementation HOT 1
- testing through ratelimit HOT 2
- Optimize NewBucketWithRateAndClock() method HOT 1
- Func `Wait` in package ratelimit could got blocked if time moves backwards for any reason HOT 1
- Question HOT 1
- Please tag a release HOT 5
- bug when system clock rollback HOT 2
- Unlimited rate after 24h? HOT 1
- It's seem that `take` would reduce the available tokens no matter the tokens are insufficient or sufficient ? HOT 1
- Concerns about license of the project.
- invalid pseudo-version: tag (v1.0.1) found on revision 59fac5042749 is already canonical, so should not be replaced with a pseudo-version derived from that tag HOT 9
- Can you remove Lock HOT 1
- If not enough tokens are available, no tokens should be removed from the bucket. HOT 2
- Request for a new release
- go get "github.com/juju/ratelimit" error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ratelimit.