Non-ISO 8601 format stored for Last modified time of object on Linux about fake-s3 HOT 6 OPEN

I worked around this locally with the following changes in lib/fakes3/file_store.rb:

86c86
<         real_obj.modified_date = metadata.fetch(:modified_date) { File.mtime(File.join(obj_root,"content")).iso8601() }
---
>         real_obj.modified_date = metadata.fetch(:modified_date) { File.mtime(File.join(obj_root,"content")).utc.iso8601() }
166c166
<         metadata_struct[:modified_date] = File.mtime(content).iso8601()
---
>         metadata_struct[:modified_date] = File.mtime(content).utc.iso8601()

from fake-s3.

@dterhorst

Great job!

from fake-s3.

I have the problem that I always get a ISO8601 formatted date, but sometimes the AWS Java SDK required a RFC822 formatted date:
https://github.com/aws/aws-sdk-java/blob/4a67bca8f1c6d5cf80a112f82d5d3a3967ebcdaf/src/main/java/com/amazonaws/services/s3/internal/AbstractS3ResponseHandler.java#L115

But usually ISO8601 is needed:
https://github.com/aws/aws-sdk-java/blob/4a67bca8f1c6d5cf80a112f82d5d3a3967ebcdaf/src/main/java/com/amazonaws/services/s3/model/transform/XmlResponsesSaxParser.java#L596

Can anyone explain to me what might be wrong here?

from fake-s3.

Dates which are HTTP header values need to follow RFC 822 as modified by RFC 1123 (spec). Dates which are XML DateTimes need to follow the XML format, which is "inspired by ISO 8601" (spec).

from fake-s3.

So, is fakes3 following that rule?

from fake-s3.

I believe that as of commit 3e2f69e fake-s3 is formatting the Last-Modified HTTP header correctly. Note that as of this writing, the latest release is v0.1.5.2 which does not contain the fix, so to get properly formatted Last-Modified header you have to check out from master.

I haven't verified the XML formatting done by fake-s3.

from fake-s3.