Type Checking integers is too loose. about json-schema HOT 3 CLOSED

The correct check for "integer" types is definitely is_int($value) without the ctype_digit($value) which returns true for strings (e.g. "12"). Strings are not valid integers according to the latest draft v4.

The "number" type also has the same problem as "integer". The code uses is_numeric($value) which returns true for strings (e.g. "12.5"). So a better check would simple reject strings altogether.

Also notable is that there are two constants declared in Constraints/Constraint.php.

const CHECK_MODE_NORMAL = 1;
const CHECK_MODE_TYPE_CAST = 2;

I searched throughout the code and found that these constants are never anywhere used except in one of the unit test files, PhpTypeCastModeTest.php. These tests are in fact erroneous.

Schema validation doesn't support casting so you can never pass a string for "integer", "number", or "boolean" types. Draft v3 and v4 compliant validation should reject strings for these types altogether.

I believe that the above constants can be removed from the code entirely and the unit test file deleted. Any new type tests can be added to existing unit test files, such as NumberAndIntegerTypesTest.php.

from json-schema.

This issue has been fixed by merging #41 into master.

from json-schema.

Thanks for adding the fix for this @mchiocca.

from json-schema.