Support octal and/or hex numbers? about json5 HOT 8 CLOSED

I think disallowing octal literals would be justified, since ES5 disallows octal literals in strict mode (see http://es5.github.com/#B.1).

from json5.

Great point! Thanks.

from json5.

Some data (using V8):

I feel like JSON5.parse('010') should throw a syntax error.
Also see https://mail.mozilla.org/pipermail/es-discuss/2009-June/009428.html, which discusses whether or not to validate octalish literals when parsing JSON and seems to reach the same consensus.

from json5.

Great point!

Looking at your hexadecimal patch, this should be straightforward to do, too, yeah? When we start with a 0, if the next character is a digit, throw an error. WDYT?

It might be nice to look into exactly what the other implementations do, to see if there are edge cases we need to account for.

Sorry, I'm completely busy in my day job right now, but I hope to take a look into this and other issues soon. Thanks for all the help!

from json5.

In strict mode, the ES5 spec, SpiderMonkey, and V8 disallow octal literals such as 07. However, in strict mode, the ES5 spec and SpiderMonkey disallow, but V8 allows, noctal literals (so-called because they have a leading 0 but non-octal digits) such as 08 or 078, which it interprets as decimal. Do you think that JSON5 should support noctal literals? I do not.

from json5.

Great catch! I agree with you — let's disallow leading 0's to avoid confusion.

from json5.

I'll update our eval tests to use strict mode (issue #14), and then I'll pull in your commit eab3058cd8. =)

from json5.

Pulled. Thanks again Max!

from json5.