Code Monkey home page Code Monkey logo

Comments (4)

jsocol avatar jsocol commented on May 15, 2024

The method of counting over time changed. Instead of relying on cache expiry (which leads to situations where good actors get blocked forever by being just a little too eager) ratelimit now calculates a fixed window that is period seconds long, and the cache key itself changes every period seconds.

from django-ratelimit.

jsocol avatar jsocol commented on May 15, 2024

See also the CHANGELOG, issue #48, and the upgrade notes.

from django-ratelimit.

bitcity avatar bitcity commented on May 15, 2024

cache key itself changes every period seconds

Oops, I overlooked this part.

However, I still have some doubt. Django has a default timeout for cache = 300 seconds. Say I have a couple of ratelimit decorators, where the slowest rate (& largest period) is 5/h (i.e. 5 requests per hour). Won't the key be lost after 300 seconds unless I explicitly change the timeout setting to be greater than say 1 hour ?

from django-ratelimit.

jsocol avatar jsocol commented on May 15, 2024

Won't the key be lost after 300 seconds unless I explicitly change the timeout setting to be greater than say 1 hour ?

Can you please test this and if so file a bug? No one has reported this issue.

from django-ratelimit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.