Code Monkey home page Code Monkey logo

Comments (4)

dohomi avatar dohomi commented on May 28, 2024 1

@jscottsmith I forgot to wrap the img src as string correctly. All good sorry for the noise and thanks for the excellent component.

from react-scroll-parallax.

jscottsmith avatar jscottsmith commented on May 28, 2024

@dohomi What browser? Support for WebP is still limited https://caniuse.com/#feat=webp

I'd recommend feature detection and pass the appropriate type of image prop to the component. Not much I can do about this in the component itself I'm afraid.

from react-scroll-parallax.

dohomi avatar dohomi commented on May 28, 2024

Hi @jscottsmith
I do webp detection and only in use with ParallaxBanner the image is not being loaded. I use an the image proxy this are the URLs maybe its because of the URL schema?

path-to-img/filters:format(webp)/account.jpg // does not work
path-to-img/account.jpg

Is there maybe an issue of using the filters:format(webp) as a string? Thats the syntax of Storyblok image proxy API.
Thanks for your swift response

from react-scroll-parallax.

jscottsmith avatar jscottsmith commented on May 28, 2024

Hmm, I'm not totally following.

Is your code publicly accessible? Might help me understand the issue more clearly. Or put together a simple demo that reproduces the issue. Happy to take a look if so.

filters:format(webp) is a transformation expression for Storyblok I guess... What's the output in the browser? Is it adding valid styles to the DOM?

<div class="parallax-banner-layer-1" style="background-image: url('https://s3-us-west-2.amazonaws.com/s.cdpn.io/105988/banner-foreground.png'); background-position: center center; background-size: cover; position: absolute; top: -25%; right: 0px; bottom: -25%; left: 0px;"></div>

from react-scroll-parallax.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.