Indexing imges with annotation leads to recursion limit reached about imantics HOT 5 CLOSED

@saurabheights looks good ill accept a pr

from imantics.

@saurabheights thanks a lot, that's great!

from imantics.

The method def index(self, image) looks for annotation in dataset annotations and tries to update its id until annotation_index has no annotation with same id. Problem is that this has been implemented in recursive manner. Since I never set annotation id as I did for images in #24 , as more annotations gets indexed, the recursive update of id keeps going deeper and deeper.

from imantics.

I've now as well hit this same error, which happens when the underlying dataset exceeds a certain size. This is indeed a critical issue, since without fixing the dataset indexing the library is unusable right now.

from imantics.

@amplejoe This below is quick fix. Hope it helps. Just incrementing it should be fine. I can make a PR, if @jsbroks is fine with it.

The quick fix basically sets id to max index_id +1. My first change was to just increment till no such id is found, but it gets pretty slow.

    def index(self, image):

        annotation_index = image.annotations
        category_index = image.categories

        if self.id < 1:
            self.id = len(annotation_index) + 1

        # Increment index until not found
        if annotation_index.get(self.id):
            self.id = max(annotation_index.keys()) + 1

        annotation_index[self.id] = self

        # Category indexing should be case insenstive
        category_name = self.category.name.lower()

        # Check if category exists
        category_found = category_index.get(category_name)
        if category_found:
            # Update category
            self.category = category_found
        else:
            # Index category
            category_index[category_name] = self.category

from imantics.