trace `return`s about js2coffee HOT 6 OPEN

Just a note to myself or whoever will take on this, this also needs some optimizations for if's (if (cond) { x } else { y } => if cond then x else y) :)

from js2coffee.

This compilation has improved since the commit that closed #42, but it still doesn't recurse.

from js2coffee.

Weird, you're right. It will recurse down to switches, but it seems to stop on nested if's.

function a() { switch (a) { case B: switch (x) { case Y: if(b) { return "hello there"; } } } } works:

a = ->
  switch a
    when B
      switch x
        when Y
          if b
            "hello there"

from js2coffee.

By the way, on second thought it's probably better for that snippet (in the original post) to compile to:

a = (b, c) ->
  if b
    2
  else
    if c
      3
    else
      4

While using the ternary operator (if x then y else z) makes the example look pretty, what would be the deciding factor on when to reduce an if/else to a single line? It may look pleasing in this theoretical example, but it can potentially ruin the readability of something else in the real world.

from js2coffee.

I've been using single-line conditonals interchangeably with multiline conditonals. I don't think this project is anywhere near the point where we start talking about formatting. If we had to, though, I'd say that condional bodies with a single statement should be pushed up next to the condition. So, by that convention, I'd compile it as

a = (b, c) ->
  if b then 2
  else
    if c then 3 else 4

from js2coffee.

The return transformer currently ignores all case statements under a switch except for the last. I have a pending, failing test for it in a commit for a related issue, test/pending/no_return_switch.*: https://github.com/dburt/js2coffee/blob/a06bf2a61e8e686cf9db858065f8a903475a9834/test/pending/no_return_switch.js

I haven't managed to solve it, but it might be a problem with Node#walk

from js2coffee.