NoMethodError: private method `save_impl' called for.. about image_voodoo HOT 6 CLOSED

@nthx could you provide a full or partial backtrace? I can read the code to try and understand what is wrong but I suspect a backtrace would make the problem obvious.

from image_voodoo.

Actually this was trivial to track down but I am a bit confused now...

https://github.com/tazsingh/carrierwave_imagevoodoo/blob/master/lib/carrierwave_imagevoodoo.rb#L154

So carrierwave_imagevoodoo calls save_impl which is currently private but I always thought this was private. Even the name implies it is private. I don't remember actually changing this but I will make it public again so that gem still works. It has to be me otherwise I don't see how this would have ever worked?

from image_voodoo.

0.8.9 has been pushed. This version also have a lot of what should be zero-sum changes due to rubocop. I was also not able to actually get carrierwave_imagevoodoo to load properly (it seems like it has not been updated in a long long time) so you will need to let me know if fixing this uncovers anything else broken.

from image_voodoo.

I will do the test with the latest release and let you know if it's fixed.
Due to the way it's setup I don't have better stack :-(

from image_voodoo.

The function is clearly public in your 0.8.2.
It went private in 0.8.6 (or before)

gems/jruby-1.7.24/gems/image_voodoo-0.8.2/lib/image_voodoo/awt.rb
LINE_99: def save_impl(format, file)
LINE_178: private

:-D

from image_voodoo.

@nthx yeah I clearly must have moved it between those two. I am not sure with the age of this gem I can hide behind the argument that it is not 1.0 yet either :)

from image_voodoo.