Code Monkey home page Code Monkey logo

Comments (5)

jroimartin avatar jroimartin commented on May 21, 2024

I'd prefer to keep views as simple as possible, think on them just as buffers. In the case of needing a title, I would add another view above just with the title (one line height, you can disable borders, etc.)

from gocui.

jroimartin avatar jroimartin commented on May 21, 2024

I've implemented this feature based on the PR #36 from @conejoninja. You can check it on branch view-title commit bb01d13. The main difference between my patch and the original PR is that I iterate over the title string, avoiding unnecessary iterations during the draw loop.

I've also added an example with all the test cases under _examples/title.go to test long titles, overlap between views, small views with title, etc.

Could you please check if it works as expected? :)

from gocui.

jroimartin avatar jroimartin commented on May 21, 2024

This is the output of _examples/title.go:

image

from gocui.

conejoninja avatar conejoninja commented on May 21, 2024

Looks good to me, no problems so far

from gocui.

jroimartin avatar jroimartin commented on May 21, 2024

Great. I've just merged it!

from gocui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.