Code Monkey home page Code Monkey logo

Comments (5)

jrendel avatar jrendel commented on July 19, 2024 1

Thanks for the suggestions. I went back and forth on what to do with remove, but I do like the idea of keeping it closer to NSUserDefaults and more consistent with the other functions.

The singleton access cleanup looks good too, I like keeping it more concise.

Everything else working for you ok? Between the unit test issues on iOS 10 simulator and CocoaPod submission problems, this update was less tested than I would have liked. But I also didn't want to delay it anymore.

from swiftkeychainwrapper.

crashoverride777 avatar crashoverride777 commented on July 19, 2024

Hey, thanks for the reply, big fan of your helper.

I have been reading through your helper and thats the 2 main things I noticed that are different from UserDefaults. If you do those changes you are basically identical.

I am not sure what singleton access you should use, I use "shared" for all my projects now (sharedInstance prior to swift 3).
Apple also seems to now use "shared" for most singletons, e.g ReplayKit.
UserDefaults uses "standard" and iCloud uses "default", so its really up to you what you prefer.

I have been using your helper since xCode 8 GM with my own changes to make it work with Swift 3. I haven't had any problems at all so far.

I just updated to your official version and everything seems fine too, I will report back incase I find something.

Thanks again for your continued support.

from swiftkeychainwrapper.

crashoverride777 avatar crashoverride777 commented on July 19, 2024

Oh yeah I opened another issue but it would be so awesome if you could provide cocoa pods support for tvOS. All my projects are iOS and tvOS universal and its a bit of a hassle without the cocoa pods support for tvOS. Is that much work for you to do? I have been using your helper for at least 8 months on tvOS and it works flawlessly.

from swiftkeychainwrapper.

jrendel avatar jrendel commented on July 19, 2024

I've update the syntax as suggested. I went with .standard for singleton access to keep consistent with UserDefaults. These are in version 2.2.1, which I'm pushing to CocoaPods now.

As for tvOS support, I will get to that eventually. I've also got requests for watchOS support and macOS support, so I need to go through them all one by one and see what is required. I think tvOS and watchOS are relatively simple.

from swiftkeychainwrapper.

crashoverride777 avatar crashoverride777 commented on July 19, 2024

Hey, thanks for the update.

In regarde to tvOS, there is literally nothing you have to do. I have been using your helper on tvOS for over 1 year and never had a problem.
Would be great if you can get cocoa pods support. I am not sure about watchOS as I dont have an apple watch.

from swiftkeychainwrapper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.