Code Monkey home page Code Monkey logo

Comments (7)

jrendel avatar jrendel commented on July 19, 2024

Check out this issue to see how it got to this point: #4

The short answer is that this was a complete Swift rewrite. But then a bug was found when compiled for release and we couldn't sort out a good solution. At the time, using the objective c wrapper was the best option.

I haven't had time to do much with this but I'm planning another rewrite for Swift 2.0. My goal is to further align it with how NSUserDefaults works and get rid of it being a static class.

from swiftkeychainwrapper.

jrendel avatar jrendel commented on July 19, 2024

Hey @lfaoro what version of the source are you looking at? I was thinking about this last night and while it was true at one point I was using the ObjC wrapper, I forgot that eventually a proper fix was found and that was taken out. The latest code in master no longer has the KeychainObjcWrapper class.

from swiftkeychainwrapper.

lfaoro avatar lfaoro commented on July 19, 2024

Hey @jrendel

I checked the source the same day I wrote the issue. I'll sync to the latest commit and check again.

Thanks!

from swiftkeychainwrapper.

jrendel avatar jrendel commented on July 19, 2024

I found the develop branch was way out of date. The master branch was getting ahead due to pull requests against it and I made some changes directly to it. So you most likely were looking at the develop branch. I merged it up to date with master this morning.

from swiftkeychainwrapper.

lfaoro avatar lfaoro commented on July 19, 2024

Well, wasn't aware of that, usually is the develop branch that is ahead of master and pull request should be sent to the develop branch :)

from swiftkeychainwrapper.

yunnnyunnn avatar yunnnyunnn commented on July 19, 2024

So...may I ask is the master branch still using KeychainObjcWrapper?

from swiftkeychainwrapper.

jrendel avatar jrendel commented on July 19, 2024

Master branch has not been using KeychainObjcWrapper for quite a few releases. And I recently updated the dev branch so its on track with master. I'm closing this issue now since its a non issue.

from swiftkeychainwrapper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.