Code Monkey home page Code Monkey logo

Comments (11)

jpuri avatar jpuri commented on June 28, 2024

Hey @nickdima: The generated output looks good here: https://jpuri.github.io/react-draft-wysiwyg/#/demo.

What is exactly issue you are facing ?

from draftjs-to-html.

jpuri avatar jpuri commented on June 28, 2024

Oh I see its issue cos of this parameter: allowFullScreen I will remove it soon.

Thanks for reporting.

from draftjs-to-html.

nickdima avatar nickdima commented on June 28, 2024

The problem is not in the editor but when you convert the article to html with draftjs-to-html

from draftjs-to-html.

jpuri avatar jpuri commented on June 28, 2024

Yep I saw its issue in generated html.

from draftjs-to-html.

nickdima avatar nickdima commented on June 28, 2024

Any idea on how to fix this?

from draftjs-to-html.

jpuri avatar jpuri commented on June 28, 2024

Hey @nickdima : Sorry for the delay, I am doing some fixes in editor today I will try to fix this also. You should have a new release of draftjs-to-html with fix by tomorrow.

from draftjs-to-html.

jpuri avatar jpuri commented on June 28, 2024

Hi @nickdima : [email protected] should fix the issue.

from draftjs-to-html.

nickdima avatar nickdima commented on June 28, 2024

Thanks @jpuri but unfortunately that fix doesn't solve the issue. The content still gets cut bellow the iframe.
I'l try to explain better what's happening.

So in my react-draft-wysiwyg editor I have this article that contains a paragraph, an iframe embed and then another paragraph. But when I load this article with draftjs-to-html it has only the first paragraph and the iframe. So any content following the iframe it doesn't get converted.
Check the attached screenshots:

Editor:

screen shot 2017-04-09 at 12 09 38


HTML (check the div container bellow and you'll see the last paragraph missing)

screen shot 2017-04-09 at 12 04 25

from draftjs-to-html.

jpuri avatar jpuri commented on June 28, 2024

Oh ok, looks like I did not correctly understood it before - I will look into it again now.

from draftjs-to-html.

nickdima avatar nickdima commented on June 28, 2024

Thanks @jpuri !

from draftjs-to-html.

nickdima avatar nickdima commented on June 28, 2024

I submitted a PR that fixes this: #14

from draftjs-to-html.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.