Code Monkey home page Code Monkey logo

Comments (5)

RyanZim avatar RyanZim commented on June 19, 2024 1

filter is passed all paths, including directories. You'll have to add logic to only run your .js check on files, and return true for directories (note that this will copy empty directories if they do not contain JS files).

from node-fs-extra.

RyanZim avatar RyanZim commented on June 19, 2024 1

Honestly, the filter probably isn't the best tool for the job here, you'd be better off using something like https://www.npmjs.com/package/globby to get a list of JS files, then copying each of them individually.

from node-fs-extra.

RyanZim avatar RyanZim commented on June 19, 2024 1

Glob support adds another entire layer of complexity and edge cases to deal with, it's unlikely we'll add it.

from node-fs-extra.

haozi avatar haozi commented on June 19, 2024

filter is passed all paths, including directories. You'll have to add logic to only run your .js check on files, and return true for directories (note that this will copy empty directories if they do not contain JS files).

but if allow folder return true, it will copy a lot of empty folder

from node-fs-extra.

haozi avatar haozi commented on June 19, 2024

Honestly, the filter probably isn't the best tool for the job here, you'd be better off using something like https://www.npmjs.com/package/globby to get a list of JS files, then copying each of them individually.

Could you consider adding support for glob matching in the first parameter?
Like:

fs.copy('src/**/*.png', dest)

from node-fs-extra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.