Comments (2)
modular was designed for applications, but honestly it seems like a good fit for building multi-package libraries too. Some concerns:
- it's a factor in renaming widgets -> modules #39 However...
- if modules aren't necessarily react components now, what will the widgets map look like? While generating the widget map won't really 'break' anything, anyone enumerating the keys of the widget map to get a list of available widgets will be mistaken. Which means we either need an opt-in metadata for widget folders/modules, or an opt-out metadata for those that aren't. (so, conceptually
widget:true
in widget package.jsons, orwidget:false
in non-widget ones. or, awidgets: [...names]
field in the root package.json) - we could try to be fancy like nx/etc and try to only publish updates to changed files, but in practice that just leads to a mad cluster in package.json of differing version numbers. Instead, let's just do it like React and update all package versions together.
shared/*
shouldn't be used for libs (else, it'll have to be published too). But now that modules/* doesn't have to be just components, devs can just make a module called 'shared' (and remember to scope it).
So what would it look like? I propose no new configuration, and two commands -
modular lib build
: creates adist/
folder, and built versions of each package undermodules
modular lib publish
: publishes the built modules.
I'll go ahead with this once we take a call on how to identify widgets/non-widgets.
from modular.
Tracking this work in #253
from modular.
Related Issues (20)
- The commands doc links are not working.
- Yarn workspace info fails to load when run with IDE debugging
- Setup `import/no-extraneous-dependencies` eslint rule to prevent extraneous dependencies being used in modular.
- Safari TP in browserlist breaks ESBUILD code path HOT 4
- Running rollup on a symlink directory causes build failures
- RFC: Modular development flows for `app` & `view` package types.
- Feature Request: Enhancement of "modular add ..."
- Remove hard-coded hashes from modular-scripts tests.
- Issues with using package.json#bin HOT 4
- Feature Request: Support for vanilla-extract CSS
- Feature: new package type "library"
- Modular lacks some nice to haves for library publishers HOT 1
- Template docs incorrect
- Workspace resolver: windows compatibility issue
- Update esbuild dependancy to support new typescript features HOT 1
- Docs site is missing a favicon HOT 1
- Getting error when running the remote views demo HOT 1
- esbuild error on node 12 HOT 1
- When installing modular-scripts an esbuild incompatible warning is produced
- Link to `commands` docs from the homepage is broken
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from modular.