Code Monkey home page Code Monkey logo

Comments (5)

TheBiggerGuy avatar TheBiggerGuy commented on June 2, 2024

This seems to be a Chrome bug (mainly to do with the fact there is no stop api). The effects are alot less when keeping the same jPlayer instance and using "setMedia".

This then brings up another unexpected behaviour. When changing "setMedia" the "ready" event does not fire.

from jplayer.

TheBiggerGuy avatar TheBiggerGuy commented on June 2, 2024

See #48

from jplayer.

 avatar commented on June 2, 2024

I had replied in the pull request...

Ok, so it is Chrome. Well, we will probably just clearMedia for everything. It sounds like it is reasonable to do this. We used to clearMedia in every setMedia, so it can't hurt to do it just before the destroy.

As for your comment about the ready event... The ready event only fires when jPlayer is instanced and is then ready for use. A setMedia command would generate a timeupdate event. There is now event specific to the setMedia command, however, I have wondered if one would be useful... Such as a newMedia event that fired after a setMedia... But I always kinda figured that if you are setting the media, you could put the code in there rather than having an event.

from jplayer.

 avatar commented on June 2, 2024

Fixed.

Minor Bug Fix: [2.0.27] The destroy() now does a clearMedia. This stops downloads from streams persisting on some browsers.

from jplayer.

TheBiggerGuy avatar TheBiggerGuy commented on June 2, 2024

Just for reference: d45a18c

from jplayer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.