Model::delete and relations, aka rails :dependent => :delete about php-activerecord HOT 1 CLOSED

Why not doing in this way? According to the docs before_* actions should stop any other action, if the return is false.
But looking to lib/Model.php this is not enforced.

with this very simple patch, if the before_* callback return false, the action is interrupted.

--- Model.php.orig  2010-03-30 03:58:07.000000000 +0200
+++ Model.php   2010-04-16 14:35:35.000000000 +0200
@@ -726,7 +726,8 @@
            return false;
 
        $table = static::table();
-       $this->invoke_callback('before_create',false);
+       if (!$this->invoke_callback('before_create',false))
+           return false;
 
        if (!($attributes = $this->dirty_attributes()))
            $attributes = $this->attributes;
@@ -791,7 +792,8 @@
            if (empty($pk))
                throw new ActiveRecordException("Cannot update, no primary key defined for: " . get_called_class());
 
-           $this->invoke_callback('before_update',false);
+           if (!$this->invoke_callback('before_update',false))
+               return false;
            $dirty = $this->dirty_attributes();
            static::table()->update($dirty,$pk);
            $this->invoke_callback('after_update',false);
@@ -814,7 +816,9 @@
        if (empty($pk))
            throw new ActiveRecordException("Cannot delete, no primary key defined for: " . get_called_class());
 
-       $this->invoke_callback('before_destroy',false);
+       if (!$this->invoke_callback('before_destroy',false))
+           return false;
+
        static::table()->delete($pk);
        $this->invoke_callback('after_destroy',false);
 

Hope is ok and can help :)

regards,
matteo

from php-activerecord.