Using rect instead of circle about react-tree-graph HOT 2 CLOSED

Changed proptype of pathFunc from string to func. It was complaining about receiving the wrong prop when I passed a function but worked fine.

Can you raise a PR for this and we'll release v4.1.1 with this fix? (So as not to require users updating to the breaking changes suggested below)

I also passed "wrappedTextProps" as the last prop to the text element, that way I can overwrite the default dx and dy props given to it.

Technically a breaking change, although I can't imagine anyone is leaving those props and relying on them being overwritten. Still, I'd suggest batching this with the main change for safety since I'm going to suggest modifications that will make it a breaking change anyway.

I created a fork where I've create a "rect" boolean prop (which will then be checked and render a rect rather than a circle) and "rectProps" used rather than circleProps.

I think it would be better if this was implemented more generically like:
shape: PropTypes.oneOf(['circle', 'rect', 'polygon']) with a default value of circle.
I'm not convinced on shape as the name of the prop though. nodeShape?

Then there would be a single prop replacing circleProps for this shape. Obviously, this is a breaking change so this would be release v5.0.0.

from react-tree-graph.

That makes a lot of sense, I'll see about making those changes this week or next week.

from react-tree-graph.