toIntent() improvement about jovo-framework HOT 7 CLOSED

Hi @terloon, thanks!

Is writing toIntentWithInputs (+ toStateIntentWithInputs, toStatelessIntentWithInputs) really that much of a timesaver compared to just adding the input as a parameter? Or are you dealing with a large amount of different inputs? Can you further elaborate why you're using _.values(app.getInputs())instead of justapp.getInputs()`?

I would do it like this:

const handlers = {
    'FirstIntent': function(name, age) {
        app.toIntent('SecondIntent', name, age);
    },
    'SecondIntent': function(name, age) {
        app.tell('Hi, your name is ' + name + ', and you are ' + age + ' years old.');
    },
}

Am I missing something?

from jovo-framework.

So my use case was:

const handlers = {
    'NEW_SESSION': function() {
        // do some prep code required by all intents...
        app.toIntent(app.getIntentName(), _values(app.getInputs());
    },
    'FirstIntent': function(one, two) {
        
    },
    'SecondIntent': function(one) {
        
    }
}

But you're right, it doesn't really save much since this is done once and in NEW_SESSION would probably where this would likely be used.

Also, new to node.js (or at least its been a while since I did javascript), but I thought doing this:

app.toIntent(app.getIntentName(), app.getInputs());

would just make the first argument (or arguments[1]) be an object like:

{
    "one": "value",
    "two": "anotherValue"
}

Closing this issue. Thanks for the feedback.

from jovo-framework.

Hi @terloon, ah I get it, you want to use it inside NEW_SESSION, this is why the number of inputs is variable.

So, you have tried just using app.toIntent(app.getIntentName()) without passing a parameter, and then accessing it, like so?

const handlers = {
    'NEW_SESSION': function() {
        // do some prep code required by all intents...
        app.toIntent(app.getIntentName());
    },
    'FirstIntent': function(one, two) {
        
    },
    'SecondIntent': function(one) {
        
    }
}

Because actually this should work (cc @aswetlow). We'll look into it

from jovo-framework.

I think I narrowed down the case where I had to do this. On the Alexa Test Simulator, if I don't pass in the input, when I perform an invocation of the voice app with a command, the input is lost.

So if my invocation is "hello world" with a skill like "start thing with number 1", if I say:

"ask hello world start thing with number 1", it would lose the slot input parameter.

from jovo-framework.

Hey yes, this is due to the 'NEW_SESSION' handler.
@aswetlow and I have recently run into the same problem and will think about a way to fix this in the upcoming version

from jovo-framework.

Gotcha. Right now I am getting around it by doing what I initially mentioned:

app.toIntent(app.getIntentName(), _.values(inputs));

from jovo-framework.

This got resolved some time ago

from jovo-framework.