xcode 9.4.1 -carthage update - 2.1.0 - error: Shorthand Operator Violation: Prefer shorthand operators (+=, -=, *=, /=) over doing the operation and assigning. (shorthand_operator) about surge HOT 6 CLOSED

from surge.

seems to bypass error.

public func det(_ x: Matrix<Double>) -> Double? {
    var decomposed = x
    var pivots = [__CLPK_integer](repeating: 0, count: min(x.rows, x.columns))
    var info = __CLPK_integer()
    var m = __CLPK_integer(x.rows)
    var n = __CLPK_integer(x.columns)
    _ = withUnsafeMutableMemory(&pivots, &(decomposed.grid)) { ipiv, grid in
        withUnsafeMutablePointers(&m, &n, &info) { m, n, info in
            dgetrf_(m, n, grid.pointer, m, ipiv.pointer, info)
        }
    }

    if info != 0 {
        return nil
    }

    var det = 1 as Double
    for (i, p) in zip(pivots.indices, pivots) {
        if p != i + 1 {
            det = -det * decomposed[i, i]
        } else {
            let detNew =  det * decomposed[i, i]
            det = detNew
        }
    }
    return det
}

from surge.

github "johndpope/Surge" ~> 2.1.1

from surge.

@johndpope You're reporting a diagnostic generated by SwiftLint. This isn't a compiler error, and doesn't inherently prevent users from building their project.

This project defines a .swiftlint.yml file, but doesn't enforce the shorthand_operator rule. Looking at this particular case, I don't agree with the advice to prefer shorthand operators, and don't believe we should opt-in to this here.

I believe the general recommendation is to exclude 3rd-party dependencies from swiftlint coverage, because such violations aren't directly actionable. You can do this by adding the following to your .swiftlint.yml file:

excluded:
- Carthage
- Pods

from surge.

Makes sense. I’m fine with this. But request that a note is added in source to point somewhere explaining this. Otherwise others will trip up and have to search around for solution. Or add to read me as known issue. Or let’s raise an issue with swift lint to rectify and link here.

from surge.

Whoops on mobile and see you’re one step ahead. Thx

from surge.