Code Monkey home page Code Monkey logo

Comments (4)

Haroenv avatar Haroenv commented on September 16, 2024 2

Technically what you’d be able to do is use the same search as for adding dependencies, and add a refinementList on objectID, with the values on the packages in dependencies (like in the Yarn site: source). Then the search will work with typo tolerance etc, and have only your dependencies.

Of course doing some offline search should also be possible (js-search by @bvaughn for example)

from guppy.

joshwcomeau avatar joshwcomeau commented on September 16, 2024 1

hi @prashant-andani,

Sorry it's taken us a couple days to get back to you.

So, because Guppy only lists direct dependencies (and not the full tree of installed dependencies), I have a hard time imagining a list of more than 30-40 dependencies, and given that they're sorted alphabetically, I don't know if I see huge value in having a search to filter by.

I certainly don't think it'd be harmful, either... but it complicates the code, and would require some design work to make sure it fits in. So truthfully I'm not sure that it's worth the cost.

Curious if others have a different feeling on the matter, but I think I'd vote against including this, at least for right now.

from guppy.

bennygenel avatar bennygenel commented on September 16, 2024 1

@joshwcomeau

If you eject a bare minimum React app, it has total of 38-40 dependencies I think. If you think about it, average user might add 8-10 new ones. List might get really crowded but yet I don't find it too difficult to scroll down. This is I think an edge case though.

Another thing I want to point out is if we should show dev and normal dependencies separately. Maybe with a tab on top of the list or something? Also this might let us give a simple UX for adding new dev dependencies.

from guppy.

joshwcomeau avatar joshwcomeau commented on September 16, 2024

If you eject a bare minimum React app, it has total of 38-40 dependencies I think. If you think about it, average user might add 8-10 new ones. List might get really crowded but yet I don't find it too difficult to scroll down. This is I think an edge case though.

Ah, that's more than I thought! For some reason I thought it was 15-20, but you're right, it's quite a few.

But yeah, I'm not sure that even for 60 dependencies, a search is warranted... I'd want to see more evidence that this is a real pain point before committing to a new feature.

Another thing I want to point out is if we should show dev and normal dependencies separately. Maybe with a tab on top of the list or something? Also this might let us give a simple UX for adding new dev dependencies.

EDIT: Moved my comments to #102. Let's leave this issue for search discussion

from guppy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.