Code Monkey home page Code Monkey logo

Comments (4)

joshkunz avatar joshkunz commented on August 26, 2024

Hm... That's not good. absl really shouldn't be getting installed at all. absl doesn't really support dynamic linking, and if absl is statically linked it doesn't need to be installed. In the log-line you pasted a static absl library is being installed, which is definitely wrong. So something is definitely broken in our configuration.

I'll take a look at this.

from ashuffle.

brainpower avatar brainpower commented on August 26, 2024

I've investigated this, too. I came up with this meson issue, which seems related:
mesonbuild/meson#2550

There's probably nothing that could be done from ashuffle's side... this needs to be fixed at meson, I think.
It should at leas offer an option or parameter to subprojects to disable installing files or something. I could not find anything like that in mesons docs, though. (I came across the above issue while searching for a solution...)

from ashuffle.

joshkunz avatar joshkunz commented on August 26, 2024

Thanks for the link @brainpower, but I think there's another issue going on here.

In the generated meson.build built by the cmake module, all the absl libraries are set with install: true. Looking at the meson source, the cmake module pulls this info straight from cmake, based on whether or not there is an "install" rule for that library.

The issue is that absl is generating these install rules when we don't want it to. absl's CMakeLists.txt decides to generate install rules depending on whether or not it is being included using add_subdirectory or built by itself. It detects this by comparing the source root with the "project" root, which would presumably not match if absl was included in another project. Since meson runs cmake on absl in isolation, absl thinks it's being built stand-alone and generates these install rules.

I've mailed out a PR to get around this (in #59). It works by tweaking the project source root to match ashuffle's root rather than absls, preventing the creation of the install rules. It prevents the install when I test locally.

from ashuffle.

joshkunz avatar joshkunz commented on August 26, 2024

This should be fixed as of v3.4.0.

from ashuffle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.