Decide on rules for naming Actions about shortcuts-js HOT 6 CLOSED

Does anyone foresee any issues with one solution over the other? If not, I'll probably go with the proposed change.

The current lint script gives an error with variable and function names not in camelCase:

ERROR: 19:7  variable-name  variable name must be in lowerCamelCase or UPPER_CASE

If new actions with names on the line of "URL From Text" will be added to Shortcuts, the proposed change won't work without modifying the linter.

It has also to be noted that in standard JS, locally upper-cased strings aren't always respected for acronyms. As an example: we have XMLHttpRequest instead of XMLHTTPRequest.

from shortcuts-js.

@joshfarrant, since #47 has been merged, now all the action function names can be replaced with the proposed ones. In that pull request I added PascalCased variable name validation in tslint.json (that was required for the private Variable class).

from shortcuts-js.

@xAlien95 I spotted that in your PR and was wondering if it would do the trick. I'm happy with that then, I'll go through and make the adjustments now.

from shortcuts-js.

The naming of showInItunesStore still makes me kind of sad to look at. Would showInITunesStore be better? And if so should runJavascriptOnWebPage be runJavaScriptOnWebPage?

from shortcuts-js.

The naming of showInItunesStore still makes me kind of sad to look at. Would showInITunesStore be better?

showInITunesStore looks better.

And if so should runJavascriptOnWebPage be runJavaScriptOnWebPage?

The original shown name is "Run JavaScript on Web Page" if I recall correctly, so runJavaScriptOnWebPage should be the right one.

from shortcuts-js.

Cool, I’ll adjust those too then.

from shortcuts-js.